Re: [PATCH v2 0/3] wifi: ath12k: some improvement to RX throughput

Baochen Qiang
2024-01-18T02:21:55Z

On 1/17/2024 11:32 PM, Jeff Johnson wrote:
> On 1/17/2024 5:46 AM, Kalle Valo wrote:
>> Baochen Qiang <quic_bqiang@quicinc.com> writes:
>>
>>> Some fields of hal_reo_update_rx_queue are wrongly
>>> defined, fix it in the first patch.
>>>
>>> Currently the maximum block ACK window size is 256,
>>> with the second patch, it is extended to BA1024.
>>>
>>> The small MAC buffer ring becomes the bottle neck
>>> in RX throughput test, so enlarge its size to get
>>> a better peak result. This is done is the third patch.
>>>
>>> With above three changes, more than 6% increase is
>>> seen in RX throughput test.
>>>
>>> v2:
>>> 1. wifi: ath12k: fix wrong definitions of hal_reo_update_rx_queue
>>> no change.
>>> 2. wifi: ath12k: add support for BA1024
>>> a) s/doen/done
>>> b) update struct hal_rx_reo_queue_1k
>>> 3. wifi: ath12k: change MAC buffer ring size to 2048
>>> no change.
>>>
>>> Baochen Qiang (3):
>>> wifi: ath12k: fix wrong definitions of hal_reo_update_rx_queue
>>> wifi: ath12k: add support for BA1024
>>> wifi: ath12k: change MAC buffer ring size to 2048
>>
>> I had conflicts, please double check:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=1ee7c1872873d82a71e05a4e17cbf9a569bc8ec9
>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=4d75db679457b5b7e04271f5174d9128d7d73ecf
>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=db549be42740d286ee6ec8b2860b4e4789be2167
>
> These look good to me, but Baochen should also confirm
>
Also looks good to me.