From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34AEBC47DA9 for ; Tue, 30 Jan 2024 01:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZPtRUycgAa9lXETMoy5ixhUG1iXxm5wZI9cIOjvtUzI=; b=dkpMzbku268n1Ht5sgMU48QOVy JGGgumuA80QcRLXtJmxAYPvH4LZoitYysevDmyg3wJX/a4KLDi4S85tGbb4v0dUKXjOBzKcLXn6WH xIGuWN/J2CHpG4GkIj1lrW0hF8P/iIq/Gv0ajIirsXOcqLIObHJYfNzCfq6Mul5+vB0K6gVFkfur9 UDL/kqj6UoIYBRD2x5PbfqP4kA3Dn6paRESkUlymQmHu7r5+J3IhDQEYRql4jSHKl6k/jBci/MYE3 CxZrBMtdYiSiAzL+UdIWeZLGSLGvKpwH2IZPP2g4+dmQvekziGmUThu501FeYisDUMWJROzNd4Mch 7k53ZsVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUd6a-0000000EqR4-3ZtV for ath12k@archiver.kernel.org; Tue, 30 Jan 2024 01:40:04 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUd6X-0000000EqN3-2NJ4 for ath12k@lists.infradead.org; Tue, 30 Jan 2024 01:40:03 +0000 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40U1VjM9021696; Tue, 30 Jan 2024 01:39:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=ZPtRUycgAa9lXETMoy5ixhUG1iXxm5wZI9cIOjvtUzI=; b=QE kky1C5MK+5C2rH0uTlSfAylNxM+0hM3PUObLpXu7mfbSIwH673acwaLOK86LvB7s vj4HHA3Yrxa21rTnbELlTkejSnKnoX2FyqyEek9fkse5UK4OVi9u4b9ZA/QoY58c 02cxIzxTRrcFEyCcyH08xwylo951WSueuSc1PM2cmgWSKDWFn+CNx4Ue2DneEdkX vxFdzom7mIhDjNGNXlKfVe0GxbtbRtfX1BtNhfM5mSdFDqxqvA1RlCeU++vKxzsF /mT2Tk+IEjjIWw6R1H2b2eonGXMsypwDLiKEbMIQ/OzB0jHsDjQzdTo4dFLVeA5L xnCaa2aeXplQkf7Smb8Q== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vx86htbsj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Jan 2024 01:39:56 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40U1dtiq030169 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Jan 2024 01:39:55 GMT Received: from [10.110.47.232] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Mon, 29 Jan 2024 17:39:55 -0800 Message-ID: Date: Mon, 29 Jan 2024 17:39:54 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 07/11] wifi: ath12k: fix broken structure wmi_vdev_create_cmd Content-Language: en-US To: Kang Yang , CC: References: <20240129101453.368494-1-quic_kangyang@quicinc.com> <20240129101453.368494-8-quic_kangyang@quicinc.com> From: Jeff Johnson In-Reply-To: <20240129101453.368494-8-quic_kangyang@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: -SXh-Rn9hPUHsXF7zLkEUB409_7Iz-h3 X-Proofpoint-GUID: -SXh-Rn9hPUHsXF7zLkEUB409_7Iz-h3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-29_15,2024-01-29_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 mlxscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 impostorscore=0 adultscore=0 clxscore=1015 mlxlogscore=733 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401190000 definitions=main-2401300009 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240129_174001_908873_5BCAE46E X-CRM114-Status: UNSURE ( 7.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org On 1/29/2024 2:14 AM, Kang Yang wrote: > Current structure wmi_vdev_create_cmd is not matched to the firmware > definition. So update it. > > And update vdev_stats_id_valid for vdev_stats_id. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Kang Yang Acked-by: Jeff Johnson FYI IMO this and the 08/11 patch should go first since they are fixing pre-existing code independent of the P2P feature (the P2P code just exposed the flaws) -- hence why I'm ack'ing these first