From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Aditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>,
Nicolas Escande <nico.escande@gmail.com>,
ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: ath12k: fix skb_ext_desc leak in ath12k_dp_tx error path
Date: Wed, 22 Jan 2025 12:19:52 -0800 [thread overview]
Message-ID: <c6b65bee-3680-4e54-9d7a-2b582461cc73@oss.qualcomm.com> (raw)
In-Reply-To: <d0dfce80-3e57-4efe-8552-b18bae9e9437@oss.qualcomm.com>
On 1/22/2025 10:20 AM, Jeff Johnson wrote:
> On 1/22/2025 8:46 AM, Aditya Kumar Singh wrote:
>> On 1/22/25 21:31, Nicolas Escande wrote:
>>> When vlan support was added, we missed that when
>>> ath12k_dp_prepare_htt_metadata returns an error we also need to free the
>>
>> nit: Always refer function name with () for clarity.
>>
>>> skb holding the metadata before going on with the cleanup process.
>>> Compile tested only.
>>>
>>> Fixes: 26dd8ccdba4d ("wifi: ath12k: dynamic VLAN support")
>>> Signed-off-by: Nicolas Escande <nico.escande@gmail.com>
>>> ---
>>
>> If there's going to be a new version please take care of above nit
>> comment. Otherwise -
>>
>> Reviewed-by: Aditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>
>>
>>
>
> I'll fixup () in both subject and description
fixup in pending:
https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=29d6569f323a88ccb3239abea562f6e691cfd9e4
next prev parent reply other threads:[~2025-01-22 20:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 16:01 [PATCH] wifi: ath12k: fix skb_ext_desc leak in ath12k_dp_tx error path Nicolas Escande
2025-01-22 16:46 ` Aditya Kumar Singh
2025-01-22 18:20 ` Jeff Johnson
2025-01-22 20:19 ` Jeff Johnson [this message]
2025-01-23 2:02 ` Aditya Kumar Singh
2025-01-23 9:26 ` Nicolas Escande
2025-01-23 16:05 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6b65bee-3680-4e54-9d7a-2b582461cc73@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=aditya.kumar.singh@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nico.escande@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox