From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3883C4167B for ; Wed, 29 Nov 2023 15:35:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mkhB+oc/0d+2BM5+G27WFV+55X05SJeWrCNbmhBuaMU=; b=u6B3yzlly2+isHyv08nbHmfDbR p6SVUR4zYkaOxbHsZhoWnkmz4MEZJb/V9fpeXi+FPe4agUEcx1xByOR5o47hLW34/VSpTlQGl9dKo G1aATDDlXD4sJt0qhqmoEnZo+yFv8mTOorpKASx4gamjcYlFZdrRT0qLXvifNC41MzyaGwSNwg2AQ fEwRc5khKr0x0OnrSzV2VH6fw8jybYQ/zh2deUBfcruUq1LUSXw3xZ2hS5GaG3ZzlGmsUj7kEcWGO YTuXRZBTX3DcwcNLUm0HSKSIF5hMYnwscDnZtb2q9pmDbmiBFEAo1mZxK7BGsZW21Vl9kHlWe7jbA rM0aH43A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8MbN-008ld4-28 for ath12k@archiver.kernel.org; Wed, 29 Nov 2023 15:35:49 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8MbL-008lcD-1n for ath12k@lists.infradead.org; Wed, 29 Nov 2023 15:35:48 +0000 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3ATEQWAA031808; Wed, 29 Nov 2023 15:35:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=mkhB+oc/0d+2BM5+G27WFV+55X05SJeWrCNbmhBuaMU=; b=cO5KGnyCSPatQ5LdVrL0OFAHFO0AFXG5hg19f3v86Z+qGzhe7r9lT401Yr8rHUOnmTPh 3twPp4lnU98zzsP50iOt2r7252iuNCdUhJnWDDZAjGxBjdd9l9g0DouYc/upiGF72B+z 8mkrJJXrRBHYkOAjn7WmWWSIoH2QQt3p/fllvGZayP7/Vb9p9ggJOq+KmDPpIs85Rv0P e0OUvu4QH79371DfPRGpgwkXHqLuTHrCNYfR8V5TJ9pSkbSPDb0rljOlNAbqIQdB/rSd /aVqiSFRdcOqYnxzoBOsJj1rqnE//PQcOCZMdikCoKYzJc+zfB4dS33vENmEkYVm0piY EQ== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3unnpetnc0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Nov 2023 15:35:46 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3ATFZjPF022136 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Nov 2023 15:35:45 GMT Received: from [10.110.63.243] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 29 Nov 2023 07:35:45 -0800 Message-ID: Date: Wed, 29 Nov 2023 07:35:44 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] wifi: ath12k: change MAC buffer ring size to 2048 Content-Language: en-US To: Baochen Qiang , CC: References: <20231129020414.56425-1-quic_bqiang@quicinc.com> <20231129020414.56425-4-quic_bqiang@quicinc.com> From: Jeff Johnson In-Reply-To: <20231129020414.56425-4-quic_bqiang@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: VhGp4JUl5GtWrK61lx_X2phg_x8y05ER X-Proofpoint-ORIG-GUID: VhGp4JUl5GtWrK61lx_X2phg_x8y05ER X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-29_13,2023-11-29_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 mlxscore=0 phishscore=0 mlxlogscore=846 priorityscore=1501 adultscore=0 clxscore=1015 bulkscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311290117 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_073547_708132_8BFCF1D5 X-CRM114-Status: GOOD ( 15.47 ) X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org On 11/28/2023 6:04 PM, Baochen Qiang wrote: > For WCN7850, there is a SRNG named MAC buffer ring, i.e., > dp->rx_mac_buf_ring. During initialization, it is setup > by host and then under control of firmware. During RX > process, firmware fetches buffers from > dp->rx_refill_buf_ring to fill that MAC buffer ring, > and those buffers are taken by RXDMA to carry real WLAN > frames received from air. > > Currently a low RX throughput is observed. Checking > firmware log, lots of errors are reported by MAC buffer > ring, complaining that it is running out of buffers, > which further indicates that RXDMA is suffering from > starvation. Currently the size of dp->rx_mac_buf_ring > is configured as 1024. After changing it to 2048, those > error messages are reduced, and a 6.4% increase is seen > in peak throughput. Note that 2048 is an empirical > value. It is chosen here because the RX throughput > meets our expectation after the change. > > This change only applies to WCN7850 since other > chips don't have a MAC buffer ring. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4 > > Signed-off-by: Baochen Qiang Acked-by: Jeff Johnson