From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AA8BC46CD2 for ; Tue, 30 Jan 2024 19:39:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oBzds0B/EJQpxf86qnK/bhlQp7r65fM7oRzat/htx1g=; b=4pQCiK4nyLgQFDF5evQmY6ZQGI E/ZruVCdODff1VSz6fjNk8w4VENPdEEJFB4hKXQvG66jGr03BQs76LxLGzvyKuEs8Zdhf9sZ4K95t D9/4MS1YJ+LyAXBWqGc3QSzFIA121bn2yS6eew1LdPUsd3k5EmO1WROCVG6gC5xVO0FfFxIL+jMBS WrYBE+4Am1so9Bvgkue1+xMdbi9WaflDMGCeewwHnU7zAv0LFDRz9rf7QKpA9Q+uUSQ7mo0+8aNRz sG2L4FefcbijkG6tGp78kID9pmOYiP5nZl6hYrISVb1u/cAX+uWTiimIOWXjsl/hAnDpkU9qaadCP +YbHmm8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUtxO-00000000MmL-3HdV for ath12k@archiver.kernel.org; Tue, 30 Jan 2024 19:39:42 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUtxM-00000000MlS-2VJf for ath12k@lists.infradead.org; Tue, 30 Jan 2024 19:39:41 +0000 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40UJUI5X010226; Tue, 30 Jan 2024 19:39:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=oBzds0B/EJQpxf86qnK/bhlQp7r65fM7oRzat/htx1g=; b=Vd LwpHlvB5JqJVaPXVdxJegfLyOGeRNfuFJNXyXeRoBRTzjviPM2+OMR+GwM8km6E8 pA+zBvHDaOf2MLDddCxMU0/i+dvCBliDK25pGxINLf9p6RrfLyi9Zw1v8oEX+2N7 o81JAakPwLFLR5ka020agEo0GT4b2e4TmMUZK41NEcGn5WxMDWJgFNNcrcM16Bl1 p6K1frFBVN6bjgqVm1PDT76uSrrqRp+Vn8xv7ZRqT2LRe6E5ceKWVmhvitwtdAvj LlS+le9R6ksM8l2urplp+2GvVhni08HlBrVlB8OHOq1fWFyqRjnnro68bffvGXnR ra/E47/B9HV08P7KPe6A== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vxvve1nmb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Jan 2024 19:39:39 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40UJdcKP020411 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Jan 2024 19:39:38 GMT Received: from [10.110.47.232] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 30 Jan 2024 11:39:37 -0800 Message-ID: Date: Tue, 30 Jan 2024 11:39:37 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] wifi: ath12k: Refactor hardware recovery synchronous Content-Language: en-US To: Karthikeyan Periyasamy , CC: References: <20240130060838.3895599-1-quic_periyasa@quicinc.com> <20240130060838.3895599-3-quic_periyasa@quicinc.com> From: Jeff Johnson In-Reply-To: <20240130060838.3895599-3-quic_periyasa@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: -_WbOUSLNxTpzWgyiJQiQEWK9LihAuPU X-Proofpoint-ORIG-GUID: -_WbOUSLNxTpzWgyiJQiQEWK9LihAuPU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-30_09,2024-01-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 mlxscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 adultscore=0 malwarescore=0 mlxlogscore=300 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401190000 definitions=main-2401300146 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240130_113940_803083_9A6AAA77 X-CRM114-Status: UNSURE ( 8.19 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org On 1/29/2024 10:08 PM, Karthikeyan Periyasamy wrote: > Currently, in multi wiphy models, radio/link level synchronization is > sufficient for MAC hardware (ieee80211_hw) reconfigure/recovery procedures > since each radio/link is exposed as a MAC hardware (ieee80211_hw). However, > in single wiphy models, multiple radio/links is exposed as a MAC hardware > (ieee80211_hw) through the driver hardware abstraction (ath12k_hw) layer. > In such scenario, we need synchronization between the reconfigure/recovery > callback operations (i.e., ath12k_core_post_reconfigure_recovery(), > ieee80211_ops->start(), ieee80211_ops->reconfig_complete(), > ieee80211_ops->stop()) at the driver hardware abstraction (ath12k_hw) layer > instead of radio/link (ath12k) layer. Therefore, introduce a new mutex in > the ath12k_hw layer. This approach ensures compatibility of the hardware > recovery procedure with both multi wiphy models and future single wiphy > models. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Karthikeyan Periyasamy Acked-by: Jeff Johnson