From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 676C3C77B61 for ; Tue, 25 Apr 2023 12:10:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3OttDBw6DWRloX7JH9zIp2Hndu0Ajz5tgEqBVGPAeWo=; b=oEL5wkD3L+Q71K GtBvpOGBzjjlJkLE6K7WCtyfuypR7416nSNtcyI8Tv9D4zeLllvet+REkVxtoUJK9Naq0+8JNBf5+ WbRSnuuw/GGT3gxt92rXBE+9VhXd6QnKv+T7D8BWzoVt3ooC/9oLwFVAdlnKbnwJbzes1Z/B0iApO khYZktxmeONaVZpYXpdSv/Aeu6nOvnTxdLymhAXQLHBsXXuvzenMtuEwLhmX725B+6cjGX9z9TOxB lkzSdhv6QKq3Cqgui1xIDOfm+dHECLkX/UAA6qVd2jTaTRyteOl3SgiCi/31GLKvHTXGOa1IZsnMU AjFUI3NRk0iWcd/hcbYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1prHVX-0012lD-0D for ath12k@archiver.kernel.org; Tue, 25 Apr 2023 12:10:55 +0000 Received: from mx01-sz.bfs.de ([194.94.69.67]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1prHVT-0012ii-2e for ath12k@lists.infradead.org; Tue, 25 Apr 2023 12:10:53 +0000 Received: from SRVEX01-MUC.bfs.intern (unknown [10.161.90.31]) by mx01-sz.bfs.de (Postfix) with ESMTPS id A6FD420752; Tue, 25 Apr 2023 14:10:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bfs.de; s=dkim201901; t=1682424631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ce7NVq8nwePgbuk3nSva2AqTwHTxJcrzIkM0P/5Y34w=; b=TgqJ8YTZyVEgVXuZue1WypK+dEUgaK6TZy2NMGxIobSduAxBio2ruUOPS3CmuRtjs1cJbY 0Nm2tkAd1z9LzveQVowC+ijV7/6CDjQW3fQIPQRl2zMBlhvb541YYiSoysvR/Tgz8amYb4 oX47TG0pyF6upnuh+fYBBQ3Raev8L7ePnE2WjyXkzvk3zp7eYwk+zi0HCR0PbZTSGLnjmx /MdKyKFTxhukgsrL1kYdBWPpBvX9AI2VZ+k2UotnXZfwynIPH9ZZ7kyhtEShyFHA1e0gnd JvWwV49+8hyB9BTUL0GWDs5PTIX16ixcCRiV5jl/I0YbH0gLvKkniTuFIT0RiQ== Authentication-Results: mx01-sz.bfs.de; none Received: from SRVEX01-MUC.bfs.intern (10.161.90.31) by SRVEX01-MUC.bfs.intern (10.161.90.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 25 Apr 2023 14:10:31 +0200 Received: from SRVEX01-MUC.bfs.intern ([fe80::e8ba:5ab1:557f:4aad]) by SRVEX01-MUC.bfs.intern ([fe80::e8ba:5ab1:557f:4aad%5]) with mapi id 15.01.2507.023; Tue, 25 Apr 2023 14:10:31 +0200 From: Walter Harms To: Christophe JAILLET , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni CC: "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" , "ath12k@lists.infradead.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" Subject: AW: [PATCH] wifi: ath12k: Remove some dead code Thread-Topic: [PATCH] wifi: ath12k: Remove some dead code Thread-Index: AQHZd20t3s5fXpiW0UuWPmJZ+6i/x6877q83 Date: Tue, 25 Apr 2023 12:10:31 +0000 Message-ID: References: In-Reply-To: Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.177.128.48] MIME-Version: 1.0 X-Spamd-Result: default: False [-18.00 / 7.00]; WHITELIST_LOCAL_IP(-15.00)[10.161.90.31]; BAYES_HAM(-3.00)[99.99%]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_TO(0.00)[wanadoo.fr,kernel.org,davemloft.net,google.com,redhat.com]; NEURAL_HAM(-0.00)[-1.000]; HAS_XOIP(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCPT_COUNT_SEVEN(0.00)[11]; DKIM_SIGNED(0.00)[bfs.de:s=dkim201901]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[wanadoo.fr]; ARC_NA(0.00)[] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230425_051052_478919_CFFA3F2A X-CRM114-Status: UNSURE ( 8.03 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org Does mcs = ATH12K_HE_MCS_MAX make sense ? re, wh ________________________________________ Von: Christophe JAILLET Gesendet: Dienstag, 25. April 2023 13:57:19 An: Kalle Valo; David S. Miller; Eric Dumazet; Jakub Kicinski; Paolo Abeni Cc: linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org; Christophe JAILLET; ath12k@lists.infradead.org; linux-wireless@vger.kernel.org; netdev@vger.kernel.org Betreff: [PATCH] wifi: ath12k: Remove some dead code ATH12K_HE_MCS_MAX = 11, so this test and the following one are the same. Remove the one with the hard coded 11 value. Signed-off-by: Christophe JAILLET --- drivers/net/wireless/ath/ath12k/dp_rx.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath12k/dp_rx.c b/drivers/net/wireless/ath/ath12k/dp_rx.c index e78478a5b978..79386562562f 100644 --- a/drivers/net/wireless/ath/ath12k/dp_rx.c +++ b/drivers/net/wireless/ath/ath12k/dp_rx.c @@ -1362,11 +1362,6 @@ ath12k_update_per_peer_tx_stats(struct ath12k *ar, * Firmware rate's control to be skipped for this? */ - if (flags == WMI_RATE_PREAMBLE_HE && mcs > 11) { - ath12k_warn(ab, "Invalid HE mcs %d peer stats", mcs); - return; - } - if (flags == WMI_RATE_PREAMBLE_HE && mcs > ATH12K_HE_MCS_MAX) { ath12k_warn(ab, "Invalid HE mcs %d peer stats", mcs); return; -- 2.34.1 -- ath12k mailing list ath12k@lists.infradead.org https://lists.infradead.org/mailman/listinfo/ath12k