From: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
To: Rajat Soni <quic_rajson@quicinc.com>, ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org,
Aditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>
Subject: Re: [PATCH ath-next 2/3] wifi: ath12k: Fix frequency range in driver
Date: Wed, 16 Apr 2025 09:34:39 +0530 [thread overview]
Message-ID: <d21bc6fd-9e16-4d36-e8cd-3bb0f43edcce@oss.qualcomm.com> (raw)
In-Reply-To: <20250408042128.720263-3-quic_rajson@quicinc.com>
On 4/8/2025 9:51 AM, Rajat Soni wrote:
> From: Aditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>
>
> During the initial WMI exchange, the firmware updates the
> hardware-supported start and end frequencies in the
> ath12k_wmi_hal_reg_capabilities_ext_arg structure. These frequencies,
> being hardware-supported, may not always align with the current
> regulatory operating frequencies. When operating as multiple grouped
> hardwares under a single wiphy, the driver advertises these values
> directly to the upper layer in the per-radio frequency range,
> which can be misleading.
>
> Sample output snippet from iw phyX info command -
>
> [..]
> Supported wiphy radios:
> * Idx 0:
> Frequency Range: 2312 MHz - 2732 MHz
> [..]
>
> * Idx 1:
> Frequency Range: 5150 MHz - 5330 MHz
> [..]
> [..]
>
> The frequency range displayed above is incorrect because the driver
> directly advertises the hardware-supported values to the upper layer.
>
> The driver is aware of the current operating regulatory rules, and
> hence it can use this information to determine the final operating
> start and end frequencies.
>
> To resolve this issue, add support to store the start and end
> frequencies received during the regulatory update event.
> Then, intersect these with the hardware-supported start and
> end frequencies, and finally, advertise the intersected values to the
> upper layer.
>
> Sample output snippet from iw phyX info command after the fix -
>
> [..]
> Supported wiphy radios:
> * Idx 0:
> Frequency Range: 2402 MHz - 2472 MHz
> [..]
>
> * Idx 1:
> Frequency Range: 5170 MHz - 5330 MHz
> [..]
> [..]
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.4.1-00199-QCAHKSWPL_SILICONZ-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>
> Signed-off-by: Aditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>
> Co-developed-by: Rajat Soni <quic_rajson@quicinc.com>
> Signed-off-by: Rajat Soni <quic_rajson@quicinc.com>
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
next prev parent reply other threads:[~2025-04-16 4:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 4:21 [PATCH ath-next 0/3] wifi: ath12k: Properly update frequency range Rajat Soni
2025-04-08 4:21 ` [PATCH ath-next 1/3] wifi: ath12k: Add helper function ath12k_mac_update_freq_range() Rajat Soni
2025-04-16 4:04 ` Vasanthakumar Thiagarajan
2025-04-08 4:21 ` [PATCH ath-next 2/3] wifi: ath12k: Fix frequency range in driver Rajat Soni
2025-04-16 4:04 ` Vasanthakumar Thiagarajan [this message]
2025-04-16 4:09 ` Vasanthakumar Thiagarajan
2025-04-16 14:42 ` Jeff Johnson
2025-04-16 16:08 ` Vasanthakumar Thiagarajan
2025-04-08 4:21 ` [PATCH ath-next 3/3] wifi: ath12k: Update frequency range if reg rules changes Rajat Soni
2025-04-16 4:15 ` Vasanthakumar Thiagarajan
2025-04-17 22:57 ` [PATCH ath-next 0/3] wifi: ath12k: Properly update frequency range Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d21bc6fd-9e16-4d36-e8cd-3bb0f43edcce@oss.qualcomm.com \
--to=vasanthakumar.thiagarajan@oss.qualcomm.com \
--cc=aditya.kumar.singh@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_rajson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox