From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AD91C4345F for ; Tue, 23 Apr 2024 01:34:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:CC:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eeCbp/i0jilK+AX4TsbSb6tiPamKPX/I2lPWXDZ7yFE=; b=JUoRlQVMOBaAzQUS1X51LKjX/i tdWDXVLnWIKOIkiOboreC44kLkmSuIm5w3OXGw4KrzO83FPs+WLISYcABFgGWqwtv/La6Ea9hkF7Y xbNsujU3qExsqn+UcSmE66kPgRYFwanwET4JnPDoEIFr60di4WXabRGmU3RI6PMoqbCW3dCeWo2U/ ib5cJ/ZXOLVwexep6SZifdnOqzzDotyjNWTE4yFYE2PyMpyFLW2YILjr5nXWl2it7ZgguNrKSHJoY UyPkXsdhhAeVP5Ep6Hmpkl1Kxly0Uq9DgHzYT2q2bpQr3i6/MuU1r18SD38bSRW5aTi25tK9rdZF+ VR5GXJIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rz53J-0000000Fg8z-2STU for ath12k@archiver.kernel.org; Tue, 23 Apr 2024 01:34:33 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rz53F-0000000Fg7P-2DcD for ath12k@lists.infradead.org; Tue, 23 Apr 2024 01:34:31 +0000 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 43N0BUel004134; Tue, 23 Apr 2024 01:34:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:from:to:cc:references :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=eeCbp/i0jilK+AX4TsbSb6tiPamKPX/I2lPWXDZ7yFE=; b=kz +fRnVGQTPjYGO6dIubcp8HwnGo++FbzR4TICYhPZOC630Qa5BnYNXxnPgY3iEV3B Tms8rXpFYtALCeJ+c6c/kurah5vbZk+J3opt3vU4752zM8KdOkmoU+5BK8YPGmbb yJ6qLVnWCHQAFu2ITY9emBLX6xtJECawNgoW9h1ftNd6guRUqnCDCZ+R3isZnqnk MIoFjqq0FxBss0v2KGU6KlUaktGMse+mtACh/5EH5SAEXrBr5tnWzpB2rYc9o5+4 A36ouu05BkL2/Me/ulOyRjG0QgHMrprVIslCPwbT292SBg0ue+1+8C55W4FpTP7o Vn2HF3sOo0lx4By4kZaw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xmxq4v493-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Apr 2024 01:34:19 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 43N1YHM5020299 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Apr 2024 01:34:17 GMT Received: from [10.110.61.159] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 22 Apr 2024 18:34:17 -0700 Message-ID: Date: Mon, 22 Apr 2024 18:34:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath12k: fix kernel crash during resume Content-Language: en-US From: Jeff Johnson To: Kalle Valo , Baochen Qiang CC: , References: <20240419034034.2842-1-quic_bqiang@quicinc.com> <87cyqmhtoi.fsf@kernel.org> <87frvivufg.fsf@kernel.org> <87h6ftv8w6.fsf@kernel.org> <5f63982a-eba9-4c5d-8ac0-52970316f940@quicinc.com> <88a1ab50-3dea-406e-adcb-b02786ce7f30@quicinc.com> In-Reply-To: <88a1ab50-3dea-406e-adcb-b02786ce7f30@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: VopR5qD8tO8Zci2_-W_Pa6wfA1vgtQ10 X-Proofpoint-ORIG-GUID: VopR5qD8tO8Zci2_-W_Pa6wfA1vgtQ10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-22_16,2024-04-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 phishscore=0 malwarescore=0 clxscore=1015 suspectscore=0 mlxlogscore=845 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2404010003 definitions=main-2404230003 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240422_183429_735838_0D808816 X-CRM114-Status: UNSURE ( 9.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org On 4/22/2024 11:41 AM, Jeff Johnson wrote: > On 4/22/2024 8:41 AM, Jeff Johnson wrote: >> On 4/22/2024 6:12 AM, Kalle Valo wrote: >>> To avoid breaking git bisect I now reshuffled the pending branch so that >>> 'wifi: ath12k: fix kernel crash during resume' is before the suspend >>> patchset and my plan is to commit the patches in same order. Does this >>> make sense for everyone? >>> >>> I had a simple conflict in ath12k_core_reset() in these commits: >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=052a6a7c74ae4f20a31a632184f4439edcb0f40c >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=6bc740619993535cb64c4dcebb83c66acd506763 >>> >>> Please check my changes. >>> >> These look OK to me. >> I'll test the pending branch on my laptop > > pending branch crashes on my laptop > let me bisect ok, that was user error. I had updated my workspace on my VM but not on my actual laptop, and the old pending branch on my laptop contained the follow patch which I've already flagged as bad (and is not present in the current pending branch): wifi: ath12k: Fix Tx Completion Ring(WBM2SW) Setup Failure I updated my laptop to: 5085843538af (origin/pending, pending) wifi: ath12k: report station mode signal strength And everything in that pending branch works fine, including hotspot. /jeff