mirror of https://lore.kernel.org/ath12k/
 help / color / mirror / Atom feed
From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>,
	<ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>,
	P Praneesh <quic_ppranees@quicinc.com>,
	Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Subject: Re: [PATCH 12/13] wifi: ath12k: fix PCI read and write
Date: Mon, 30 Oct 2023 18:04:32 -0700	[thread overview]
Message-ID: <eaa58dd0-dc90-476f-83df-ea9437e04ab0@quicinc.com> (raw)
In-Reply-To: <20231030222700.18914-13-quic_rajkbhag@quicinc.com>

On 10/30/2023 3:26 PM, Raj Kumar Bhagat wrote:
> From: P Praneesh <quic_ppranees@quicinc.com>
> 
> Currently, PCI read is failing for the registers belonging to
> SECURITY_CONTROL_WLAN registers. These registers read is required
> to read the board-id to identify the dual-mac QCN9274 hardware.
> 
> The failure is because, for these registers (SECURITY_CONTROL_WLAN)
> offset, ath12k_pci_get_window_start() returns window_start as 0. Due
> to this PCI read is done without PCI select window and with
> window_start offset as 0.
> 
> Hence, fix PCI read and write by doing PCI select window and by using
> the correct window_start offset - WINDOW_START for
> SECURITY_CONTROL_WLAN registers.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00188-QCAHKSWPL_SILICONZ-1
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: P Praneesh <quic_ppranees@quicinc.com>
> Co-developed-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>

Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>


-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k

  reply	other threads:[~2023-10-31  1:04 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-30 22:26 [PATCH 00/13] wifi: ath12k: QCN9274 dualmac bring up Raj Kumar Bhagat
2023-10-30 22:26 ` [PATCH 01/13] wifi: ath12k: Update enum wmi_direct_buffer_module Raj Kumar Bhagat
2023-10-30 22:43   ` Jeff Johnson
2023-10-30 22:26 ` [PATCH 02/13] wifi: ath12k: indicate NON MBSSID vdev by default during vdev start Raj Kumar Bhagat
2023-10-30 23:12   ` Jeff Johnson
2024-01-05 18:35     ` Raj Kumar Bhagat
2023-10-30 22:26 ` [PATCH 03/13] wifi: ath12k: fetch correct pdev id from WMI_SERVICE_READY_EXT_EVENTID Raj Kumar Bhagat
2023-10-30 23:14   ` Jeff Johnson
2023-10-30 22:26 ` [PATCH 04/13] wifi: ath12k: add support for peer meta data version Raj Kumar Bhagat
2023-10-30 23:16   ` Jeff Johnson
2023-10-30 22:26 ` [PATCH 05/13] wifi: ath12k: fix fetching MCBC flag for QCN9274 Raj Kumar Bhagat
2023-10-30 23:17   ` Jeff Johnson
2023-10-30 22:26 ` [PATCH 06/13] wifi: ath12k: Add logic to write QRTR node id to scratch Raj Kumar Bhagat
2023-10-30 23:18   ` Jeff Johnson
2023-11-02 15:33   ` Kalle Valo
2023-10-30 22:26 ` [PATCH 07/13] wifi: ath12k: fix firmware assert during insmod in memory segment mode Raj Kumar Bhagat
2023-10-30 23:27   ` Jeff Johnson
2023-10-30 22:26 ` [PATCH 08/13] wifi: ath12k: split hal_ops to support RX TLVs word mask compaction Raj Kumar Bhagat
2023-10-30 23:33   ` Jeff Johnson
2023-10-30 22:26 ` [PATCH 09/13] wifi: ath12k: remove hal_desc_sz from hw params Raj Kumar Bhagat
2023-10-30 23:34   ` Jeff Johnson
2023-10-30 22:26 ` [PATCH 10/13] wifi: ath12k: subscribe required word mask from rx tlv Raj Kumar Bhagat
2023-10-31  0:53   ` Jeff Johnson
2024-01-05 18:42     ` Raj Kumar Bhagat
2023-10-30 22:26 ` [PATCH 11/13] wifi: ath12k: add MAC id support in WBM error path Raj Kumar Bhagat
2023-10-31  1:01   ` Jeff Johnson
2023-10-30 22:26 ` [PATCH 12/13] wifi: ath12k: fix PCI read and write Raj Kumar Bhagat
2023-10-31  1:04   ` Jeff Johnson [this message]
2023-10-30 22:27 ` [PATCH 13/13] wifi: ath12k: Read board id to support split-PHY QCN9274 Raj Kumar Bhagat
2023-10-31  1:06   ` Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eaa58dd0-dc90-476f-83df-ea9437e04ab0@quicinc.com \
    --to=quic_jjohnson@quicinc.com \
    --cc=ath12k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_periyasa@quicinc.com \
    --cc=quic_ppranees@quicinc.com \
    --cc=quic_rajkbhag@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox