From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Aditya Kumar Singh <quic_adisi@quicinc.com>,
Kalle Valo <kvalo@kernel.org>, Jeff Johnson <jjohnson@kernel.org>,
Karthikeyan Periyasamy <quic_periyasa@quicinc.com>,
Harshitha Prem <quic_hprem@quicinc.com>
Cc: Kalle Valo <quic_kvalo@quicinc.com>,
linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/10] wifi: ath12k: fix ath12k_core_pre_reconfigure_recovery() with grouping
Date: Mon, 13 Jan 2025 11:22:41 -0800 [thread overview]
Message-ID: <f3e8a292-9d2a-40df-a595-bc0917def320@oss.qualcomm.com> (raw)
In-Reply-To: <20250109-fix_reboot_issues_with_hw_grouping-v1-6-fb39ec03451e@quicinc.com>
On 1/8/2025 8:25 PM, Aditya Kumar Singh wrote:
> Currently, ath12k_core_pre_reconfigure_recovery() reconfigures all radios
> within the same group. During grouping and driver going for a recovery,
> this function is called as many times as there are devices in the group.
> Consequently, it performs the same reconfiguration multiple times, which
> is unnecessary.
>
> To prevent this, add a check to continue if the action has already been
> taken.
>
> To simplify the management of various flags, the reason for hardware queues
> being stopped is used as a check instead of introducing a new flag.
>
> While at it, also add missing wiphy locks. Wiphy lock is required since
> ath12k_mac_drain_tx() which is called by
> ath12k_core_pre_reconfigure_recovery() needs this lock to be held by the
> caller.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
Acked-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
next prev parent reply other threads:[~2025-01-13 19:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 4:25 [PATCH 00/10] wifi: ath12k: fixes for rmmod and recovery issues with hardware grouping Aditya Kumar Singh
2025-01-09 4:25 ` [PATCH 01/10] wifi: ath12k: prevent race condition in ath12k_core_hw_group_destroy() Aditya Kumar Singh
2025-01-13 19:06 ` Jeff Johnson
2025-01-09 4:25 ` [PATCH 02/10] wifi: ath12k: add reference counting for core attachment to hardware group Aditya Kumar Singh
2025-01-13 19:06 ` Jeff Johnson
2025-01-09 4:25 ` [PATCH 03/10] wifi: ath12k: fix failed to set mhi state error during reboot with hardware grouping Aditya Kumar Singh
2025-01-13 19:07 ` Jeff Johnson
2025-01-09 4:25 ` [PATCH 04/10] wifi: ath12k: fix firmware assert " Aditya Kumar Singh
2025-01-13 19:12 ` Jeff Johnson
2025-01-16 10:43 ` Aditya Kumar Singh
2025-01-09 4:25 ` [PATCH 05/10] wifi: ath12k: fix SLUB BUG - Object already free in ath12k_reg_free() Aditya Kumar Singh
2025-01-13 19:21 ` Jeff Johnson
2025-01-20 8:38 ` Aditya Kumar Singh
2025-01-09 4:25 ` [PATCH 06/10] wifi: ath12k: fix ath12k_core_pre_reconfigure_recovery() with grouping Aditya Kumar Singh
2025-01-13 19:22 ` Jeff Johnson [this message]
2025-01-09 4:25 ` [PATCH 07/10] wifi: ath12k: fix ATH12K_FLAG_REGISTERED flag handling Aditya Kumar Singh
2025-01-13 19:23 ` Jeff Johnson
2025-01-09 4:25 ` [PATCH 08/10] wifi: ath12k: handle ath12k_core_restart() with hardware grouping Aditya Kumar Singh
2025-01-13 19:23 ` Jeff Johnson
2025-01-09 4:25 ` [PATCH 09/10] wifi: ath12k: handle ath12k_core_reset() " Aditya Kumar Singh
2025-01-13 19:24 ` Jeff Johnson
2025-01-09 4:25 ` [PATCH 10/10] wifi: ath12k: reset MLO global memory during recovery Aditya Kumar Singh
2025-01-13 19:25 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3e8a292-9d2a-40df-a595-bc0917def320@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_adisi@quicinc.com \
--cc=quic_hprem@quicinc.com \
--cc=quic_kvalo@quicinc.com \
--cc=quic_periyasa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox