public inbox for ath12k@lists.infradead.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
	Kiran Venkatappa <quic_kiranv@quicinc.com>,
	ath12k@lists.infradead.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH ath12k-ng 03/13] wifi: ath12k: Move Wi-Fi 7 WMI configuration to dedicated file
Date: Wed, 13 Aug 2025 18:00:44 +0200	[thread overview]
Message-ID: <f6b046b0-d230-41e6-ab18-686cc7b65f16@kernel.org> (raw)
In-Reply-To: <b62af6d9-eea1-41d0-997d-b9585f2a9533@oss.qualcomm.com>

On 13/08/2025 17:43, Jeff Johnson wrote:
> On 8/12/2025 10:52 PM, Krzysztof Kozlowski wrote:
>> On 12/08/2025 19:09, Kiran Venkatappa wrote:
>>> +}
>>> diff --git a/drivers/net/wireless/ath/ath12k/wmi_wifi7.h b/drivers/net/wireless/ath/ath12k/wmi_wifi7.h
>>> new file mode 100644
>>> index 0000000000000000000000000000000000000000..1514e3e8d4cb65d3d95d95a1c1593a7b66abcf58
>>> --- /dev/null
>>> +++ b/drivers/net/wireless/ath/ath12k/wmi_wifi7.h
>>> @@ -0,0 +1,15 @@
>>> +/* SPDX-License-Identifier: BSD-3-Clause-Clear */
>>> +/*
>>> + * Copyright (c) 2018-2021 The Linux Foundation. All rights reserved.
>>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
>>
>> Don't rewrite the copyrights. Original file had different one. GPL FAQ
>> also EXPLICITLY asks for date in copyrights and does not allow one
>> without the date.
>>
>> (and before you bring internal qcom regulations, let me remind that they
>> do not matter. we discussed this in other thread)
> 
> Wi-Fi team wasn't party to the other thread, and this series was following the
> legal guidance we were given. I'm circling with the core kernel team and the
> legal team to make sure your concerns are resolved.

+Cc Greg,

Please follow legal guidance expressed in:
https://www.gnu.org/licenses/gpl-howto.en.html#copyright-notice

and the license you agreed by signing of the patch:
LICENSES/preferred/GPL-2.0:

"Copyright (C) <year>  <name of author> "
...
"... publish on each copy an appropriate
copyright notice and disclaimer of warranty;"

Just to remind - you as author sign off your patch, not your legal team.

Best regards,
Krzysztof


  reply	other threads:[~2025-08-13 16:37 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-12 17:09 [PATCH ath12k-ng 00/13] wifi: ath12k: Ath12k modularization changes Kiran Venkatappa
2025-08-12 17:09 ` [PATCH ath12k-ng 01/13] wifi: ath12k: Restructure PCI code to common and Wi-Fi 7 specific logic Kiran Venkatappa
2025-08-12 17:09 ` [PATCH ath12k-ng 02/13] wifi: ath12k: Move Copy Engine configuration to Wi-Fi 7 specific file Kiran Venkatappa
2025-08-12 17:09 ` [PATCH ath12k-ng 03/13] wifi: ath12k: Move Wi-Fi 7 WMI configuration to dedicated file Kiran Venkatappa
2025-08-13  5:52   ` Krzysztof Kozlowski
2025-08-13 15:43     ` Jeff Johnson
2025-08-13 16:00       ` Krzysztof Kozlowski [this message]
2025-08-13 16:24         ` Greg Kroah-Hartman
2025-08-13 18:06           ` Jeff Johnson
2025-08-12 17:09 ` [PATCH ath12k-ng 04/13] wifi: ath12k: Move Wi-Fi 7 MHI " Kiran Venkatappa
2025-08-13  5:52   ` Krzysztof Kozlowski
2025-08-12 17:09 ` [PATCH ath12k-ng 05/13] wifi: ath12k: Rename hw.c to Wi-Fi 7 specific implementation file Kiran Venkatappa
2025-08-12 17:09 ` [PATCH ath12k-ng 06/13] wifi: ath12k: Rename ahb_hif_ops to reflect generic usage Kiran Venkatappa
2025-08-12 17:09 ` [PATCH ath12k-ng 07/13] wifi: ath12k: Restructure ahb.c into common and Wi-Fi 7 specific modules Kiran Venkatappa
2025-08-12 17:09 ` [PATCH ath12k-ng 08/13] wifi: ath12k: Move Wi-Fi 7 specific init routines to dedicated file Kiran Venkatappa
2025-08-12 17:09 ` [PATCH ath12k-ng 09/13] wifi: ath12k: Move hw_init invocation to target-specific probe Kiran Venkatappa
2025-08-12 17:09 ` [PATCH ath12k-ng 10/13] wifi: ath12k: Modularize driver into common and Wi-Fi 7 specific components Kiran Venkatappa
2025-08-12 17:09 ` [PATCH ath12k-ng 11/13] wifi: ath12k: Rename ath12k_* symbols to ath12k_wifi7_* for clarity Kiran Venkatappa
2025-08-12 17:09 ` [PATCH ath12k-ng 12/13] wifi: ath12k: Remove HAL defines from shared PCI code Kiran Venkatappa
2025-08-12 17:09 ` [PATCH ath12k-ng 13/13] wifi: ath12k: Remove HAL define dependencies from shared AHB code Kiran Venkatappa
2025-08-20  4:50 ` [PATCH ath12k-ng 00/13] wifi: ath12k: Ath12k modularization changes Vasanthakumar Thiagarajan
2025-08-20  7:11 ` Baochen Qiang
2025-08-20 20:57   ` Jeff Johnson
2025-08-21  1:46     ` Baochen Qiang
2025-08-20 21:44 ` Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6b046b0-d230-41e6-ab18-686cc7b65f16@kernel.org \
    --to=krzk@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeff.johnson@oss.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_kiranv@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox