From mboxrd@z Thu Jan  1 00:00:00 1970
From: Johannes Berg <johannes@sipsolutions.net>
Date: Fri, 01 Jun 2012 08:44:30 +0200
Subject: [ath9k-devel] [PATCH] ath9k: Fix a WARNING in suspend/resume
	with IBSS
In-Reply-To: <1338532779-4621-1-git-send-email-mohammed@qca.qualcomm.com>
	(sfid-20120601_083956_399882_A3D65832)
References: <1338532779-4621-1-git-send-email-mohammed@qca.qualcomm.com>
	(sfid-20120601_083956_399882_A3D65832)
Message-ID: <1338533070.4884.4.camel@jlt3.sipsolutions.net>
List-Id: <ath9k-devel.lists.ath9k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ath9k-devel@lists.ath9k.org

On Fri, 2012-06-01 at 12:09 +0530, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
> 
> In ath9k we make sure the following two things
> *if the first interface is ADHOC we cannot have any other interface.
> *we cannot add an ADHOC interface if there is already an interface
> is present.

> -	if ((ah->opmode == NL80211_IFTYPE_ADHOC) ||
> -	    ((vif->type == NL80211_IFTYPE_ADHOC) &&
> -	     sc->nvifs > 0)) {
> -		ath_err(common, "Cannot create ADHOC interface when other"
> -			" interfaces already exist.\n");
> +	if ((ah->opmode == NL80211_IFTYPE_ADHOC) && (sc->nvifs > 0)) {
> +		ath_err(common, "Cannot create any other interface when an ADHOC interface already exists.\n");
> +		ret = -EINVAL;
> +		goto out;
> +	}
> +
> +	if ((vif->type == NL80211_IFTYPE_ADHOC) && (sc->nvifs > 0)) {
> +		ath_err(common, "Cannot create ADHOC interface when other interfaces already exist.\n");

You could just remove the entire check since the interface combinations
you advertise don't allow it, I think? Or just fix those
combinations :-)

johannes