From mboxrd@z Thu Jan  1 00:00:00 1970
From: Johannes Berg <johannes@sipsolutions.net>
Date: Thu, 31 Jan 2013 16:20:48 +0100
Subject: [ath9k-devel] [PATCH 5/7] mac80211: Expand powersave
 configuration flag to be two bits
In-Reply-To: <1359503255-18270-6-git-send-email-seth.forshee@canonical.com>
References: <1359503255-18270-1-git-send-email-seth.forshee@canonical.com>
	<1359503255-18270-6-git-send-email-seth.forshee@canonical.com>
Message-ID: <1359645648.8415.77.camel@jlt4.sipsolutions.net>
List-Id: <ath9k-devel.lists.ath9k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ath9k-devel@lists.ath9k.org

On Tue, 2013-01-29 at 17:47 -0600, Seth Forshee wrote:

> +static inline bool ieee80211_is_ps_disabled(struct ieee80211_conf *conf)

> +static inline bool ieee80211_is_ps_enabled(struct ieee80211_conf *conf)

Huh, is that worth the confusion? It seems !enabled should be the same
as disabled, but it's not quite the same, which might be confusing.

> +/**
> + * ieee80211_set_ps_state - set device powersave state
> + *
> + * Sets the powersave state in the supplied device configuration to the
> + * specified state.
> + *
> + * @conf: device configuration
> + * @state: new powersave state. Must be one of the IEEE80211_CONF_PS_*
> + *	flags from enum ieee80211_conf_flags.
> + */
> +static inline void ieee80211_set_ps_state(struct ieee80211_conf *conf,
> +					  u32 state)
> +{
> +	conf->flags = (conf->flags & ~IEEE80211_CONF_PS_MASK) |
> +		      (state & IEEE80211_CONF_PS_MASK);
> +}

I don't think the driver should do this, so the inline shouldn't be
here?

johannes