From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joe Perches <joe@perches.com>
Date: Sun, 20 Dec 2015 10:47:08 -0800
Subject: [ath9k-devel] [patch -next] ath9k: fix
	ath9k_hw_nvram_check_version()
In-Reply-To: <20151219105919.GB3749@mwanda>
References: <20151219105919.GB3749@mwanda>
Message-ID: <1450637228.3430.30.camel@perches.com>
List-Id: <ath9k-devel.lists.ath9k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ath9k-devel@lists.ath9k.org

On Sat, 2015-12-19 at 13:59 +0300, Dan Carpenter wrote:
> There is a type bug so it always returns success.

How many false positives do you have to sift
through to find this sort of error?

> +++ b/drivers/net/wireless/ath/ath9k/eeprom.c
> @@ -206,7 +206,7 @@ bool ath9k_hw_nvram_check_version(struct ath_hw *ah, int version, int minrev)
> ?		ath_err(common, "Bad EEPROM VER 0x%04x or REV 0x%04x\n",
> ?			ah->eep_ops->get_eeprom_ver(ah),
> ?			ah->eep_ops->get_eeprom_rev(ah));
> -		return -EINVAL;
> +		return false;
> ?	}
> ?
> ?	return true;