From: Benjamin Berg <benjamin@sipsolutions.net>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 1/6] ath9k: Correct TSF adjustment to align the beacon time correctly
Date: Tue, 7 Jun 2016 15:09:56 +0200 [thread overview]
Message-ID: <1465305001-26067-1-git-send-email-benjamin@sipsolutions.net> (raw)
From: Benjamin Berg <benjamin.berg@open-mesh.com>
Beacons need to be send out at timestamp % beacon_time == 0.
Signed-off-by: Benjamin Berg <benjamin.berg@open-mesh.com>
---
drivers/net/wireless/ath/ath9k/beacon.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/beacon.c b/drivers/net/wireless/ath/ath9k/beacon.c
index 5cf0cd7..800c96b 100644
--- a/drivers/net/wireless/ath/ath9k/beacon.c
+++ b/drivers/net/wireless/ath/ath9k/beacon.c
@@ -279,17 +279,21 @@ static void ath9k_set_tsfadjust(struct ath_softc *sc, struct ieee80211_vif *vif)
struct ath_common *common = ath9k_hw_common(sc->sc_ah);
struct ath_vif *avp = (void *)vif->drv_priv;
struct ath_beacon_config *cur_conf = &avp->chanctx->beacon;
- u32 tsfadjust;
+ s64 tsfadjust;
if (avp->av_bslot == 0)
return;
+ /* tsf_adjust is added to the TSF value. We send out the beacon late,
+ * so need to adjust the TSF starting point to be later in time (i.e.
+ * the theoretical first beacon has a TSF of 0 after correction).
+ */
tsfadjust = cur_conf->beacon_interval * avp->av_bslot;
- tsfadjust = TU_TO_USEC(tsfadjust) / ATH_BCBUF;
+ tsfadjust = -TU_TO_USEC(tsfadjust) / ATH_BCBUF;
avp->tsf_adjust = cpu_to_le64(tsfadjust);
- ath_dbg(common, CONFIG, "tsfadjust is: %llu for bslot: %d\n",
- (unsigned long long)tsfadjust, avp->av_bslot);
+ ath_dbg(common, CONFIG, "tsfadjust is: %lld for bslot: %d\n",
+ (signed long long)tsfadjust, avp->av_bslot);
}
bool ath9k_csa_is_finished(struct ath_softc *sc, struct ieee80211_vif *vif)
--
2.8.1
next reply other threads:[~2016-06-07 13:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 13:09 Benjamin Berg [this message]
2016-06-07 13:09 ` [ath9k-devel] [PATCH 2/6] ath9k: Handle channel context in get_/set_/reset_tsf Benjamin Berg
2016-06-09 10:37 ` Kalle Valo
2016-06-07 13:09 ` [ath9k-devel] [PATCH 3/6] ath9k: Use tsf offset helper in ath9k_hw_reset Benjamin Berg
2016-06-09 10:39 ` Kalle Valo
2016-06-07 13:09 ` [ath9k-devel] [PATCH 4/6] ath9k: Expose tsf_adjustment in mac80211 tsf getters and setters Benjamin Berg
2016-06-09 10:42 ` Kalle Valo
2016-06-07 13:10 ` [ath9k-devel] [PATCH 5/6] ath9k: Use defined constants consistently Benjamin Berg
2016-06-07 13:32 ` Felix Fietkau
2016-06-07 13:10 ` [ath9k-devel] [PATCH 6/6] ath9k: Fix beacon configuration for addition/removal of interfaces Benjamin Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465305001-26067-1-git-send-email-benjamin@sipsolutions.net \
--to=benjamin@sipsolutions.net \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).