[ath9k-devel] kernel panic with ath9k

[Pavel Roskin <proski@gnu.org>]

On Wed, 15 Feb 2012 21:18:36 +0530
Mohammed Shafi <shafi.wireless@gmail.com> wrote:

> if we refer rate_control_get_rate in rate.c of mac80211
> 
> for (i = 0; i < IEEE80211_TX_MAX_RATES; i++) {
> 		info->control.rates[i].idx = -1;
> 		info->control.rates[i].flags = 0;
> 		info->control.rates[i].count = 1;
> 	}

Thanks for finding this code!  That's another sign that my patch is not
hiding an underlying problem, such as memory corruption.

> why count = 1 not 0 ? if count has to be 0 then we should fix in
> mac80211 also. though the doc in mac80211 says idx -1 means invalid
> rate, did not say if count =0 invalid
> but anyway the rate is tried once ?
> 
> *now  the drivers assumption of count=0 for invalid is not correct i
> think ministrel checks for both index and count in
> 'minstrel_ht_txstat_valid' while ath9k does not before your patch

We should remove the checks for count=0 eventually.  But it's not a
change for stable kernels.

-- 
Regards,
Pavel Roskin