From: John W. Linville <linville@tuxdriver.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: Show actual timeout value in failed calibration messages.
Date: Wed, 27 Mar 2013 11:04:28 -0400 [thread overview]
Message-ID: <20130327150428.GB1868@tuxdriver.com> (raw)
In-Reply-To: <CAMgrJ3YYZuR2oN9p4jMXvEd22aU+O69Bv-M5uOEO-FUZkdf_MA@mail.gmail.com>
Missing a Signed-off-by line...
On Sun, Mar 24, 2013 at 02:25:02PM -0400, Robert Shade wrote:
> The messages are currently hard coding "1ms", which does not match
> the actual timeout being used.
> ---
> drivers/net/wireless/ath/ath9k/ar9002_calib.c | 9 ++++++---
> drivers/net/wireless/ath/ath9k/ar9003_calib.c | 3 ++-
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/ar9002_calib.c
> b/drivers/net/wireless/ath/ath9k/ar9002_calib.c
> index c55e5bb..9f58974 100644
> --- a/drivers/net/wireless/ath/ath9k/ar9002_calib.c
> +++ b/drivers/net/wireless/ath/ath9k/ar9002_calib.c
> @@ -731,7 +731,8 @@ static bool ar9285_hw_cl_cal(struct ath_hw *ah,
> struct ath9k_channel *chan)
> if (!ath9k_hw_wait(ah, AR_PHY_AGC_CONTROL,
> AR_PHY_AGC_CONTROL_CAL, 0, AH_WAIT_TIMEOUT)) {
> ath_dbg(common, CALIBRATE,
> - "offset calibration failed to complete in 1ms; noisy environment?\n");
> + "offset calibration failed to complete in %d ms; noisy environment?\n",
> + AH_WAIT_TIMEOUT / 1000);
> return false;
> }
> REG_CLR_BIT(ah, AR_PHY_TURBO, AR_PHY_FC_DYN2040_EN);
> @@ -745,7 +746,8 @@ static bool ar9285_hw_cl_cal(struct ath_hw *ah,
> struct ath9k_channel *chan)
> if (!ath9k_hw_wait(ah, AR_PHY_AGC_CONTROL, AR_PHY_AGC_CONTROL_CAL,
> 0, AH_WAIT_TIMEOUT)) {
> ath_dbg(common, CALIBRATE,
> - "offset calibration failed to complete in 1ms; noisy environment?\n");
> + "offset calibration failed to complete in %d ms; noisy environment?\n",
> + AH_WAIT_TIMEOUT / 1000);
> return false;
> }
>
> @@ -841,7 +843,8 @@ static bool ar9002_hw_init_cal(struct ath_hw *ah,
> struct ath9k_channel *chan)
> AR_PHY_AGC_CONTROL_CAL,
> 0, AH_WAIT_TIMEOUT)) {
> ath_dbg(common, CALIBRATE,
> - "offset calibration failed to complete in 1ms; noisy environment?\n");
> + "offset calibration failed to complete in %d ms; noisy environment?\n",
> + AH_WAIT_TIMEOUT / 1000);
> return false;
> }
>
> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_calib.c
> b/drivers/net/wireless/ath/ath9k/ar9003_calib.c
> index f76c3ca..639ba7d 100644
> --- a/drivers/net/wireless/ath/ath9k/ar9003_calib.c
> +++ b/drivers/net/wireless/ath/ath9k/ar9003_calib.c
> @@ -1126,7 +1126,8 @@ skip_tx_iqcal:
> ar9003_hw_rtt_disable(ah);
>
> ath_dbg(common, CALIBRATE,
> - "offset calibration failed to complete in 1ms; noisy environment?\n");
> + "offset calibration failed to complete in %d ms; noisy environment?\n",
> + AH_WAIT_TIMEOUT / 1000);
> return false;
> }
>
> --
> 1.7.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
John W. Linville Someday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2013-03-27 15:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-24 18:25 [ath9k-devel] [PATCH] ath9k: Show actual timeout value in failed calibration messages Robert Shade
2013-03-27 15:04 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327150428.GB1868@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox