Historical ath9k-devel archives
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 2/2] ath10k: only warn about incompatible firmware versions
Date: Thu, 02 May 2013 12:02:23 +0300	[thread overview]
Message-ID: <20130502090223.2932.24852.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20130502090142.2932.3314.stgit@localhost6.localdomain6>

Most of the time it does more harm than good to halt the
driver initialisation if the firmware version is not
supported. For example, sometimes it's good to test
something from older versions etc. So just change the
check to a warning.

Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath10k/core.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index a511aaf..475ca1a 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -84,10 +84,11 @@ static int ath10k_check_fw_version(struct ath10k *ar)
 		 SUPPORTED_FW_MAJOR, SUPPORTED_FW_MINOR,
 		 SUPPORTED_FW_RELEASE, SUPPORTED_FW_BUILD);
 
-	ath10k_err("Firmware %s is not supported. Please use version %s (or newer)\n",
-		   ar->hw->wiphy->fw_version, version);
+	ath10k_warn("WARNING: Firmware version %s is not officially supported.\n",
+		    ar->hw->wiphy->fw_version);
+	ath10k_warn("Please upgrade to version %s (or newer)\n", version);
 
-	return -EINVAL;
+	return 0;
 }
 
 static int ath10k_init_connect_htc(struct ath10k *ar)

  parent reply	other threads:[~2013-05-02  9:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-02  9:02 [ath9k-devel] [PATCH 0/2] ath10k: firmware version related changes Kalle Valo
2013-05-02  9:02 ` [ath9k-devel] [PATCH 1/2] ath10k: print firmware version string during boot Kalle Valo
2013-05-02  9:02 ` Kalle Valo [this message]
2013-05-02  9:18   ` [ath9k-devel] [PATCH 2/2] ath10k: only warn about incompatible firmware versions Michal Kazior
2013-05-04  5:44     ` Kalle Valo
2013-05-04  5:46 ` [ath9k-devel] [PATCH 0/2] ath10k: firmware version related changes Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130502090223.2932.24852.stgit@localhost6.localdomain6 \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox