From: Thomas Huehn <thomas@net.t-labs.tu-berlin.de>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [ath5k-devel] [PATCH 2/2] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path
Date: Tue, 17 Jul 2012 14:57:35 +0200 [thread overview]
Message-ID: <5005613F.1000004@net.t-labs.tu-berlin.de> (raw)
In-Reply-To: <1342518290.7427.9.camel@jlt3.sipsolutions.net>
Hi Johannes,
Johannes Berg schrieb:
> Ok first of all, please actually compile the tree after your changes. It
> doesn't. When it does, please fix
I always do compile the compat-wireless-tree after changes I introduce,
and it compiles without errors in the case of this mac80211:sta-remove
patch. But as my build tree is based on the OpenWrt environment, it
might be not 100% in sync. Could you be a bit more explicit where does
it brake in you case (which function, driver...) ?
> 1) line length in the commit log should be < 72 chars
Will do so in v2.
> 3) removal of an important comment in mac80211.h that I pointed out in
> previous review
next prev parent reply other threads:[~2012-07-17 12:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 18:52 [ath9k-devel] mac80211: Restructure ieee80211_tx_info->control to gain free space along tx-path Thomas Huehn
2012-07-13 18:52 ` [ath9k-devel] [PATCH 1/2] mac80211_hwsim: fix possible race condition in usage of info->control.sta & control.vif Thomas Huehn
2012-07-13 18:52 ` [ath9k-devel] [PATCH 2/2] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path Thomas Huehn
2012-07-14 10:10 ` Arend van Spriel
2012-07-14 11:44 ` Felix Fietkau
2012-07-14 12:55 ` Arend van Spriel
2012-07-15 4:49 ` Luciano Coelho
2012-07-17 9:44 ` Johannes Berg
2012-07-17 12:57 ` Thomas Huehn [this message]
2012-07-17 13:03 ` [ath9k-devel] [ath5k-devel] " Johannes Berg
2012-07-17 20:33 ` Thomas Huehn
2012-07-18 6:48 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5005613F.1000004@net.t-labs.tu-berlin.de \
--to=thomas@net.t-labs.tu-berlin.de \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).