From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: Ensure we set FTP_STOMP_LOW weight when WLAN is idle
Date: Fri, 28 Sep 2012 14:57:19 +0530 [thread overview]
Message-ID: <50656D77.4040101@qca.qualcomm.com> (raw)
In-Reply-To: <CAOpc7mF8XTnW5gh7hnN=7e_M7f=wRVuPqT_7S9k2YN7tq4YXBw@mail.gmail.com>
Hi Holger,
On Friday 28 September 2012 02:30 PM, Holger Schurig wrote:
>> We WLAN is idle we can some better bandwidth to FTP by
>> setting STOMP_LOW_FTP where stomping the FTP BT is pretty
>> much reduced when compared to setting STOMP_LOW weight.
>
> I understand that english isn't your first language (and neither is it
> mine). But this is quite unintelligible.
:) :)
apologies, I simply missed the commit log line, Its been sent as an RFC
sometime and yesterday I sent the patch, apparently not much looking
into the commit log :). Definitely its not correct and thanks for
pointing this out. Will send a v2!
>
> Beside wrong words (We/When) it doesn't also really say what is going
> on. What, for example, is FTP ? How can you assume that this is
> generally known? For sure it's not the file transfer protocol. Same
> with "FTP BT".
sure I would make it clear in the v2.
>
> Also, "we can some better bandwidth" misses a verb. "take into account
> of data packets" is weird, too.
sure, I will change in v2.
>
> Confused.
>
thanks a lot for your review and comments!
--
thanks,
shafi
prev parent reply other threads:[~2012-09-28 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 15:12 [ath9k-devel] [PATCH] ath9k: Ensure we set FTP_STOMP_LOW weight when WLAN is idle Mohammed Shafi Shajakhan
2012-09-28 9:00 ` Holger Schurig
2012-09-28 9:27 ` Mohammed Shafi Shajakhan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50656D77.4040101@qca.qualcomm.com \
--to=mohammed@qca.qualcomm.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox