From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zefir Kurtisi Date: Tue, 16 Apr 2013 14:10:26 +0200 Subject: [ath9k-devel] [patch] ath9k: use GFP_ATOMIC under spinlock In-Reply-To: <20130416075128.GB1571@elgon.mountain> References: <20130416075128.GB1571@elgon.mountain> Message-ID: <516D3FB2.7070005@neratec.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On 04/16/2013 09:51 AM, Dan Carpenter wrote: > This is called with spinlocks held so we have to use GFP_ATOMIC. It's > the sc_pcu_lock in ath9k_stop() that's the issue. The call tree looks > like this: > > ath9k_stop() > ath_prepare_reset() > ath_stoprecv() > ath_flushrecv() > ath_rx_tasklet() > ath9k_dfs_process_phyerr() > pd->add_pulse() => dpd_add_pulse() > channel_detector_get() > channel_detector_create() > pri_detector_init() > > channel_detector_create() uses GFP_ATOMIC as well. > > Signed-off-by: Dan Carpenter > --- > Static analysis stuff. I haven't tested this but it looks like a real > bug to me. > Thanks Dan, it is a bug that slipped through the related patch in [1]. Tested-by & Acked-by: Zefir Kurtisi [1] http://article.gmane.org/gmane.linux.kernel.wireless.general/106349/