From: Michal Kazior <michal.kazior@tieto.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 1/5] ath10k: replace debug_mtx with conf_mutex
Date: Thu, 18 Apr 2013 11:48:58 +0200 [thread overview]
Message-ID: <516FC18A.5050205@tieto.com> (raw)
In-Reply-To: <87ip3kqijo.fsf@kamboji.qca.qualcomm.com>
On 18/04/13 11:44, Kalle Valo wrote:
> Michal Kazior <michal.kazior@tieto.com> writes:
>
>> It's not a good to have too many mutexes. The
>> patch simplifies locking of debufs to use
>> conf_mutex.
>>
>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>
> [...]
>
>> @@ -328,7 +328,7 @@ int ath10k_debug_create(struct ath10k *ar)
>> return -ENOMEM;
>>
>> init_completion(&ar->debug.event_stats_compl);
>> - mutex_init(&ar->debug.debug_mtx);
>> + mutex_init(&ar->conf_mutex);
>
> Can this be right? We already initialise conf_mutex in core.c.
Good catch, thanks! The mutex_init() is already initialized elsewhere.
No need to re-initialize it here.
-- Pozdrawiam / Best regards, Michal Kazior.
next prev parent reply other threads:[~2013-04-18 9:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 6:04 [ath9k-devel] [PATCH 0/5] ath10k: cleanups Michal Kazior
2013-04-17 6:04 ` [ath9k-devel] [PATCH 1/5] ath10k: replace debug_mtx with conf_mutex Michal Kazior
2013-04-18 9:44 ` Kalle Valo
2013-04-18 9:48 ` Michal Kazior [this message]
2013-04-17 6:04 ` [ath9k-devel] [PATCH 2/5] ath10k: change wmi structure access Michal Kazior
2013-04-17 6:04 ` [ath9k-devel] [PATCH 3/5] ath10k: fix coding style Michal Kazior
2013-04-17 6:04 ` [ath9k-devel] [PATCH 4/5] ath10k: use ath10k_warn() instead of ath10k_info() Michal Kazior
2013-04-17 6:04 ` [ath9k-devel] [PATCH 5/5] ath10k: fix function prototype argument name Michal Kazior
2013-04-18 9:50 ` [ath9k-devel] [PATCH 0/5] ath10k: cleanups Kalle Valo
2013-04-18 10:01 ` [ath9k-devel] [PATCH v2 " Michal Kazior
2013-04-18 10:01 ` [ath9k-devel] [PATCH v2 1/5] ath10k: replace debug_mtx with conf_mutex Michal Kazior
2013-04-18 10:01 ` [ath9k-devel] [PATCH v2 2/5] ath10k: change wmi structure access Michal Kazior
2013-04-18 10:01 ` [ath9k-devel] [PATCH v2 3/5] ath10k: fix coding style Michal Kazior
2013-04-18 10:01 ` [ath9k-devel] [PATCH v2 4/5] ath10k: use ath10k_warn() instead of ath10k_info() Michal Kazior
2013-04-18 10:01 ` [ath9k-devel] [PATCH v2 5/5] ath10k: fix function prototype argument name Michal Kazior
2013-04-22 8:10 ` [ath9k-devel] [PATCH v2 0/5] ath10k: cleanups Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516FC18A.5050205@tieto.com \
--to=michal.kazior@tieto.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox