From: Markowski Bartosz <bartosz.markowski@tieto.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 1/3] ath10k: kill A_PCIE_LOCAL_REG_READ
Date: Tue, 23 Apr 2013 09:30:44 +0200 [thread overview]
Message-ID: <517638A4.3090701@tieto.com> (raw)
In-Reply-To: <87d2tlg0wi.fsf@kamboji.qca.qualcomm.com>
On 23/04/13 09:29, Kalle Valo wrote:
> Bartosz Markowski <bartosz.markowski@tieto.com> writes:
>
>> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com>
> [...]
>
>> -#define A_PCIE_LOCAL_REG_READ(mem, addr) \
>> - ioread32((mem) + PCIE_LOCAL_BASE_ADDRESS_T(ar) + (u32)(addr))
> I think it would be better to convert this to a function and call it
> ath10k_pci_reg_read32() or something like that. And the same for the
> write function.
>
ok
next prev parent reply other threads:[~2013-04-23 7:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 13:23 [ath9k-devel] [PATCH 0/3] ath10k: kill unnecessary macros Bartosz Markowski
2013-04-22 13:23 ` [ath9k-devel] [PATCH 1/3] ath10k: kill A_PCIE_LOCAL_REG_READ Bartosz Markowski
2013-04-23 7:29 ` Kalle Valo
2013-04-23 7:30 ` Markowski Bartosz [this message]
2013-04-22 13:23 ` [ath9k-devel] [PATCH 2/3] ath10k: kill A_PCIE_LOCAL_REG_WRITE Bartosz Markowski
2013-04-22 13:23 ` [ath9k-devel] [PATCH 3/3] ath10k: fix comment to reflect time in mili-seconds Bartosz Markowski
2013-04-23 7:32 ` [ath9k-devel] [PATCH 0/3] ath10k: kill unnecessary macros Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517638A4.3090701@tieto.com \
--to=bartosz.markowski@tieto.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox