From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksij Rempel Date: Thu, 02 May 2013 19:32:49 +0200 Subject: [ath9k-devel] [PATCH 1/2] ath9k_htc: add STBC TX support In-Reply-To: References: <1367482308-9882-1-git-send-email-linux@rempel-privat.de> <1367482308-9882-2-git-send-email-linux@rempel-privat.de> Message-ID: <5182A341.8050704@rempel-privat.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Am 02.05.2013 18:55, schrieb Adrian Chadd: > On 2 May 2013 01:11, Oleksij Rempel wrote: > >> +#define WLAN_RC_TX_STBC_FLAG 0x20 /* TX STBC */ >> +#define WLAN_RC_RX_STBC_FLAG 0xC0 /* RX STBC ,2 bits */ > > I thought we covered this; why are you marking two bits here? becouse firmware checks for two bits (and then use it as bool ;)), so i pass what firmware can handle. > Atheros 11n hardware only supports 1-stream STBC RX. Did you got my email with lots of assumptions and questions? What do you mean by 1-stream STBC RX? After i did some home work on STBC i see that it encoded from at least two spatial streams. Is 1-stream STBC RX = 2 spatial streams with mirrored data? and 2-stream STBC RX = 4 spatial streams with mirrored data? or 1-stream STBC RX = compatibility mode for one stream hardware(so only of two streams received)? That would make sense for 1x1:1 hardware, but if you say all atheros N hardware support only 1-stream STBC RX, will mean that STBC is useless on this hardware. > Have you verified that we're actually negotiating 1-stream STBC RX > with a peer? (Ie, by looking at packet captures?) Yes, i wrote this too :) I verified it, we negotiate only 1-stream STBC RX. -- Regards, Oleksij