From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksij Rempel Date: Sat, 04 May 2013 20:29:43 +0200 Subject: [ath9k-devel] [PATCH 1/2] ath9k_htc: add STBC TX support In-Reply-To: References: <1367482308-9882-1-git-send-email-linux@rempel-privat.de> <1367482308-9882-2-git-send-email-linux@rempel-privat.de> <5182A341.8050704@rempel-privat.de> <5182A9DC.6030203@openwrt.org> <5184AFC2.8060101@rempel-privat.de> <5184DCCF.9010009@openwrt.org> <5184EC19.9060206@rempel-privat.de> <5184EE0B.1030605@openwrt.org> Message-ID: <51855397.1020802@rempel-privat.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Am 04.05.2013 19:50, schrieb Adrian Chadd: > I've just reviewed it myself: > > * oan->stbc is enabled only if the hardware itself supports STBC; so > it's an extra sanity check in case the firmware is told to enable STBC > in the WMI capflag field. all STBC parts are not compiled for AR9271. Currently firmware will do sanity check on htc_7010.fw and always return 1, and wont do any check on htc_9271.fw (this part is just not compiled). > * is oan->htinfo used anywhere that may involve STBC? hmm...oan->htinfo? > * .. we should check whether ath9k_htc ever set the STBC flags on > AR9271, or we'd end up confusing the hardware. no, never. there are legion guardians ;) last on is on preparing tx descriptor. > * .. I don't think that is important though, as we weren't _doing_ STBC, right? correct, currently STBC is not working on linux ath9k_htc > * Why are the ATH_RC_* flags used in newassoc_11n? This comes from the > WMI WMI_RC_STATE_CHANGE_CMDID capflag field; where are _those_ > defined? they are in target_firmware/wlan/if_athrate.h and well, there are a bit more problems thin them. See attachment :) Attached patch can go on top of my merge request for firmware. So, i will probably need to make Patch_v5 for ath9k_htc... since. Felix, > In addition to that, using the WLAN_RC_* flags is wrong, you need to use > the ATH_RC_* flags,... After some firmware cleaning i will need to use WLAN_RC_* flags :) WLAN_RC_* have same values like ATH_RC_*... > Grr, so many things to tidy up. -- Regards, Oleksij -------------- next part -------------- A non-text attachment was scrubbed... Name: tmp_2.diff Type: text/x-patch Size: 2393 bytes Desc: not available Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20130504/50e3eb32/attachment.bin