From: Michal Kazior <michal.kazior@tieto.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 1/2] ath10k: Convert ath10k_dbg uses
Date: Thu, 16 May 2013 10:25:41 +0200 [thread overview]
Message-ID: <51949805.7010509@tieto.com> (raw)
In-Reply-To: <1368687816.2194.49.camel@joe-AO722>
On 16/05/13 09:03, Joe Perches wrote:
> Neaten and shorten the uses of ath10k_dbg and ath10k_dbg_dump.
>
> Add macros to hold the "ATH10K_DBG_" mask portion of the functions.
I'm not really fond of this idea. It's harder to locate symbols when
doing macro name concatenation. You can't jump to, e.g. WMI symbol
definition because it doesn't exist (ATH10K_DBG_WMI is what you actually
want). Although you don't look for this symbol often so I guess it's
okay-ish.
-- Pozdrawiam / Best regards, Michal Kazior.
next prev parent reply other threads:[~2013-05-16 8:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130515143356.4492.43033.stgit@localhost6.localdomain6>
[not found] ` <1368639816.2194.9.camel@joe-AO722>
[not found] ` <8761yknn7i.fsf@kamboji.qca.qualcomm.com>
2013-05-16 7:03 ` [ath9k-devel] [PATCH 1/2] ath10k: Convert ath10k_dbg uses Joe Perches
2013-05-16 8:25 ` Michal Kazior [this message]
2013-05-20 7:12 ` Kalle Valo
2013-05-20 16:01 ` Joe Perches
2013-05-20 18:43 ` Kalle Valo
2013-05-16 7:05 ` [ath9k-devel] [PATCH 2/2] ath10k: Neaten ath10k_<level> uses Joe Perches
2013-06-01 9:19 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51949805.7010509@tieto.com \
--to=michal.kazior@tieto.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox