From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michal Kazior <michal.kazior@tieto.com>
Date: Tue, 11 Jun 2013 07:37:42 +0200
Subject: [ath9k-devel] [PATCH 02/10] ath10k: decouple core init/deinit
 logic
In-Reply-To: <87hah5ucts.fsf@kamboji.qca.qualcomm.com>
References: <1370514361-15858-1-git-send-email-michal.kazior@tieto.com>
	<1370514361-15858-3-git-send-email-michal.kazior@tieto.com>
	<87hah5ucts.fsf@kamboji.qca.qualcomm.com>
Message-ID: <51B6B7A6.5060707@tieto.com>
List-Id: <ath9k-devel.lists.ath9k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ath9k-devel@lists.ath9k.org

On 10/06/13 18:53, Kalle Valo wrote:
> Michal Kazior <michal.kazior@tieto.com> writes:
>
>> Enables code reuse for proper hw reconfiguration
>> that is in turn required for proper
>> suspend/hibernation/wowlan support.
>>
>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>
> Let's have a terminology check. I have understood we use terms with
> meaning like this (maybe you have been thinking something else):
>
> init(): initilises the module in question from host side, allocates
>          memory etc. Called only once when driver is loaded.
>
> deinit(): reverse action for init(), frees allocated memory etc. Called
>            only once.
>
> start(): Initialises hw/fw. Called every time we start the firmware.
>
> stop(): Kills the running fw. Shuts down all power the device (when
>          possible)
>
> But here ath10k_core_init() seems to be initialising hw/fw. So should it
> be renamed to ath10k_core_start()?

You're right. I'll fix this and resend.


-- Pozdrawiam / Best regards, Michal Kazior.