From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksij Rempel Date: Sat, 15 Mar 2014 08:51:31 +0100 Subject: [ath9k-devel] [PATCH 00/23] ath9k|ath9k_htc: move dups to common-beacon In-Reply-To: <20140314192212.GD20339@tuxdriver.com> References: <1393704966-13985-1-git-send-email-linux@rempel-privat.de> <21266.37896.937680.416439@gargle.gargle.HOWL> <5312DD46.3030800@rempel-privat.de> <21266.58035.719712.344551@gargle.gargle.HOWL> <20140306184235.GA7788@tuxdriver.com> <5319978F.6060803@rempel-privat.de> <21273.40172.734118.220513@gargle.gargle.HOWL> <531DD589.1090109@rempel-privat.de> <20140314192212.GD20339@tuxdriver.com> Message-ID: <53240683.1000305@rempel-privat.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Am 14.03.2014 20:22, schrieb John W. Linville: > On Mon, Mar 10, 2014 at 04:08:57PM +0100, Oleksij Rempel wrote: >> Am 07.03.2014 11:18, schrieb Sujith Manoharan: >>> Oleksij Rempel wrote: >>>> Last response was about initvals, my patch set affect only beacon code. >>>> Since i don't plan to rewrite ath9k_htc from scratch, i would assume it >>>> will be better to continue this periodic clean work. >>> >>> I didn't review the patches, but someone else needs to make sure that >>> nothing is broken in ath9k. >> >> I use this code one week ind STA mode. But if you need more directed >> alternate testing, who is good candidate for this work? > > I applied the series and attempted a build. But... > > CC drivers/net/wireless/ath/ath9k/tx99.o > In file included from include/linux/bitops.h:33:0, > from include/linux/kernel.h:10, > from include/linux/skbuff.h:17, > from include/linux/if_ether.h:23, > from include/linux/etherdevice.h:25, > from drivers/net/wireless/ath/ath9k/ath9k.h:20, > from drivers/net/wireless/ath/ath9k/tx99.c:17: > drivers/net/wireless/ath/ath9k/tx99.c: In function ?ath9k_tx99_init?: > drivers/net/wireless/ath/ath9k/tx99.c:111:15: error: ?SC_OP_INVALID? undeclared (first use in this function) > if (test_bit(SC_OP_INVALID, &sc->sc_flags)) { > ^ > /home/linville/git/wireless-next/arch/x86/include/asm/bitops.h:338:25: note: in definition of macro ?test_bit? > (__builtin_constant_p((nr)) \ > ^ > drivers/net/wireless/ath/ath9k/tx99.c:111:15: note: each undeclared identifier is reported only once for each function it appears in > if (test_bit(SC_OP_INVALID, &sc->sc_flags)) { > ^ > /home/linville/git/wireless-next/arch/x86/include/asm/bitops.h:338:25: note: in definition of macro ?test_bit? > (__builtin_constant_p((nr)) \ > ^ > drivers/net/wireless/ath/ath9k/tx99.c:111:33: error: ?struct ath_softc? has no member named ?sc_flags? > if (test_bit(SC_OP_INVALID, &sc->sc_flags)) { > ^ > /home/linville/git/wireless-next/arch/x86/include/asm/bitops.h:339:30: note: in definition of macro ?test_bit? > ? constant_test_bit((nr), (addr)) \ > ^ > drivers/net/wireless/ath/ath9k/tx99.c:111:33: error: ?struct ath_softc? has no member named ?sc_flags? > if (test_bit(SC_OP_INVALID, &sc->sc_flags)) { > ^ > /home/linville/git/wireless-next/arch/x86/include/asm/bitops.h:340:30: note: in definition of macro ?test_bit? > : variable_test_bit((nr), (addr))) > ^ > make[3]: *** [drivers/net/wireless/ath/ath9k/tx99.o] Error 1 > make[2]: *** [drivers/net/wireless/ath/ath9k] Error 2 > make[1]: *** [drivers/net/wireless/ath] Error 2 > make: *** [drivers/net/wireless/] Error 2 > > I'll be backing this out for now... thank you. I missed CONFIG_EXPERT :/ in attachment is second version of affected patch. -- Regards, Oleksij -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-ath9k-move-sc_flags-to-ath_common.patch Type: text/x-patch Size: 20132 bytes Desc: not available Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20140315/18cd76cb/attachment-0001.bin