[ath9k-devel] [PATCH] Adding support for spectral scan for the ath9k_htc driver. Tested the patch on with 9271 chipset to generate spectral scans.

From: Oleksij Rempel <linux@rempel-privat.de>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] Adding support for spectral scan for the ath9k_htc driver. Tested the patch on with 9271 chipset to generate spectral scans.
Date: Mon, 07 Apr 2014 20:10:14 +0200	[thread overview]
Message-ID: <5342EA06.9030107@rempel-privat.de> (raw)
In-Reply-To: <CAFT2d76PKKnYakHZ8x=t+-oX-MJgNkbObbosacd_=uiVncHwUw@mail.gmail.com>

Am 07.04.2014 19:21, schrieb Ashish Patro:
> Hi Oleksij,
> 
> I didn't want to poke too much into the ath9k part of the driver code,
> so I wrote it in the current way. All the duplicated code is currently
> present in spectral_htc.c. The debugFS related code needs to be mostly
> duplicated to provide the same interface for ath9k and ath9k_htc drivers.
> 
> The common code can be later moved into ath_common. The main issue is
> that the current ath9k code is using references to ath_softc, so the
> common code needs to be written to be independent of ath_softc and
> ath9k_htc_priv data structures.

Correct. spectral.c has no too deep ath_softc dependencies, it can be
solved.
I don't like the idea of having patch which i already know, that i will
need rework it. Ath9k-htc has not enough developers, the goal is to
reduce work, not increase it.

> On Mon, Apr 7, 2014 at 8:47 AM, Oleksij Rempel <linux@rempel-privat.de
> <mailto:linux@rempel-privat.de>> wrote:
> 
>     Am 07.04.2014 01:23, schrieb Ashish Patro:
>     > - Used the same mechanism to collect spectral scan data as used by
>     the existing ath9k code.
>     > - Minor refactoring done to the code to separate the ath9k and
>     ath9k_htc related spectral scan functions into separate files.
>     >
>     > This work was done at the WiNGS Lab at the University of Wisconsin
>     Madison.
> 
>     Current patch produce lots of duplicated code with ath9k. It will
>     increase work later. I guess you plan to fix? ;)
> 
>     --
>     Regards,
>     Oleksij
> 
> 
>     _______________________________________________
>     ath9k-devel mailing list
>     ath9k-devel at lists.ath9k.org <mailto:ath9k-devel@lists.ath9k.org>
>     https://lists.ath9k.org/mailman/listinfo/ath9k-devel
> 
> 

-- 
Regards,
Oleksij

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 278 bytes
Desc: OpenPGP digital signature
Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20140407/03c50324/attachment.pgp 