Historical ath9k-devel archives
 help / color / mirror / Atom feed
From: Oleksij Rempel <linux@rempel-privat.de>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 1/3] Moving the ath9k specific spectral functions to ath9k.h from spectral.h
Date: Mon, 14 Apr 2014 22:24:44 +0200	[thread overview]
Message-ID: <534C440C.8070807@rempel-privat.de> (raw)
In-Reply-To: <1397500183-10884-2-git-send-email-patro@cs.wisc.edu>

Am 14.04.2014 20:29, schrieb Ashish Patro:
> ---
>  drivers/net/wireless/ath/ath9k/ath9k.h    |   19 +++++++++++++++++++
>  drivers/net/wireless/ath/ath9k/spectral.h |   19 -------------------
>  2 files changed, 19 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h b/drivers/net/wireless/ath/ath9k/ath9k.h
> index 44d7449..5a85b3b 100644
> --- a/drivers/net/wireless/ath/ath9k/ath9k.h
> +++ b/drivers/net/wireless/ath/ath9k/ath9k.h
> @@ -834,4 +834,23 @@ static inline int ath_ahb_init(void) { return 0; };
>  static inline void ath_ahb_exit(void) {};
>  #endif
>  
> +void ath9k_spectral_init_debug(struct ath_softc *sc);
> +void ath9k_spectral_deinit_debug(struct ath_softc *sc);
> +
> +void ath9k_spectral_scan_trigger(struct ieee80211_hw *hw);
> +int ath9k_spectral_scan_config(struct ieee80211_hw *hw,
> +			       enum spectral_mode spectral_mode);
> +
> +#ifdef CONFIG_ATH9K_DEBUGFS
> +int ath_process_fft(struct ath_softc *sc, struct ieee80211_hdr *hdr,
> +		    struct ath_rx_status *rs, u64 tsf);
> +#else
> +static inline int ath_process_fft(struct ath_softc *sc,
> +				  struct ieee80211_hdr *hdr,
> +				  struct ath_rx_status *rs, u64 tsf)
> +{
> +	return 0;
> +}
> +#endif /* CONFIG_ATH9K_DEBUGFS */

It is ok to place them here, but i would prefer to have them in
common-spectral.h

>  #endif /* ATH9K_H */
> diff --git a/drivers/net/wireless/ath/ath9k/spectral.h b/drivers/net/wireless/ath/ath9k/spectral.h
> index ead6341..d321f7f 100644
> --- a/drivers/net/wireless/ath/ath9k/spectral.h
> +++ b/drivers/net/wireless/ath/ath9k/spectral.h
> @@ -190,23 +190,4 @@ struct fft_sample_ht20_40 {
>  	u8 data[SPECTRAL_HT20_40_NUM_BINS];
>  } __packed;
>  
> -void ath9k_spectral_init_debug(struct ath_softc *sc);
> -void ath9k_spectral_deinit_debug(struct ath_softc *sc);
> -
> -void ath9k_spectral_scan_trigger(struct ieee80211_hw *hw);
> -int ath9k_spectral_scan_config(struct ieee80211_hw *hw,
> -			       enum spectral_mode spectral_mode);
> -
> -#ifdef CONFIG_ATH9K_DEBUGFS
> -int ath_process_fft(struct ath_softc *sc, struct ieee80211_hdr *hdr,
> -		    struct ath_rx_status *rs, u64 tsf);
> -#else
> -static inline int ath_process_fft(struct ath_softc *sc,
> -				  struct ieee80211_hdr *hdr,
> -				  struct ath_rx_status *rs, u64 tsf)
> -{
> -	return 0;
> -}
> -#endif /* CONFIG_ATH9K_DEBUGFS */
> -
>  #endif /* SPECTRAL_H */
> 


-- 
Regards,
Oleksij

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 278 bytes
Desc: OpenPGP digital signature
Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20140414/df1f1527/attachment.pgp 

  reply	other threads:[~2014-04-14 20:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-14 18:29 [ath9k-devel] [PATCH 0/3] Refactoring spectral scan code and add support for ath9k_htc Ashish Patro
2014-04-14 18:29 ` [ath9k-devel] [PATCH 1/3] Moving the ath9k specific spectral functions to ath9k.h from spectral.h Ashish Patro
2014-04-14 20:24   ` Oleksij Rempel [this message]
2014-04-14 18:29 ` [ath9k-devel] [PATCH 2/3] Refactoring the ath9k driver to move common spectral functions to common-spectral.c Ashish Patro
2014-04-14 20:33   ` Oleksij Rempel
2014-04-14 18:29 ` [ath9k-devel] [PATCH 3/3] Adding spectral scan functionality to ath9k_htc driver. Tested using a AR9271 WiFi card Ashish Patro
2014-04-14 20:49   ` Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=534C440C.8070807@rempel-privat.de \
    --to=linux@rempel-privat.de \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox