From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksij Rempel Date: Sat, 16 May 2015 07:43:16 +0200 Subject: [ath9k-devel] [PATCH] ath9k: add phy.c In-Reply-To: <1431754580.15709.55.camel@perches.com> References: <1431693340-8861-1-git-send-email-linux@rempel-privat.de> <1431714904.15709.24.camel@perches.com> <5556D546.6010703@rempel-privat.de> <1431754580.15709.55.camel@perches.com> Message-ID: <5556D8F4.5010509@rempel-privat.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Am 16.05.2015 um 07:36 schrieb Joe Perches: > On Sat, 2015-05-16 at 07:27 +0200, Oleksij Rempel wrote: > >> Am 15.05.2015 um 20:35 schrieb Joe Perches: >>> On Fri, 2015-05-15 at 14:35 +0200, Oleksij Rempel wrote: >>>> ... and move dup code from ar5008_phy.c and ar9002_phy.c to phy.c >>> [] >>>> diff --git a/drivers/net/wireless/ath/ath9k/phy.c b/drivers/net/wireless/ath/ath9k/phy.c >>> >>>> +void phy_hw_spur_mitigate(struct ath_hw *ah, >>>> + struct ath9k_channel *chan, int bin) >>>> +{ > [] >>>> + static int inc[4] = { 0, 100, 0, 0 }; >>> >>> static const > >> This is cleanup patch, no fixes optimisations >> or regressions should be introduced. > > Hello Oleksij. > > One of the old compilation units (ar9002_phy.c) had const on > all those arrays, the other did not. ok, thanks. changed to const version. > const should be used here. > >> If you see some problems in this >> code, you are welcome to provide a patch on top of this one :) > > I think you should take comments on the patches you submit. What do you mean? -- Regards, Oleksij -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 230 bytes Desc: OpenPGP digital signature Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20150516/742ce16b/attachment.pgp