From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felix Fietkau Date: Mon, 22 Jun 2015 19:58:03 +0200 Subject: [ath9k-devel] [PATCH 2/3] ath9k: make rxfilter per HW In-Reply-To: <1434974380.19597.10.camel@sipsolutions.net> References: <1434973385-15865-1-git-send-email-janusz.dziedzic@tieto.com> <1434973385-15865-3-git-send-email-janusz.dziedzic@tieto.com> (sfid-20150622_134339_744222_8D689257) <1434974312.19597.9.camel@sipsolutions.net> (sfid-20150622_135841_850054_31462557) <1434974380.19597.10.camel@sipsolutions.net> Message-ID: <55884CAB.6050308@openwrt.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On 2015-06-22 13:59, Johannes Berg wrote: > On Mon, 2015-06-22 at 13:58 +0200, Johannes Berg wrote: >> On Mon, 2015-06-22 at 13:43 +0200, Janusz Dziedzic wrote: >> > mac80211 configure rxfilter per HW, >> > so we don't need this per channel. >> >> As I said before, I think there's value in mac80211 doing it per chanctx >> or even per vif, and it should be more efficient to do so. >> >> It's tempting to do it per vif and leave the chanctx work up to the >> driver, but perhaps with CSA and all that it gets complicated enough >> that doing it per chanctx in mac80211 would make sense? > > On the other hand, I think our device requires it per vif, so we'd > probably have to do both. > > +Andrei, who was looking into this. There's value in it, but I think it makes more sense to fix this bug now, and rework the code again later when mac80211 has support for per-vif or per-chanctx rxfilter. - Felix