From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Mon, 20 May 2013 21:43:22 +0300 Subject: [ath9k-devel] [PATCH 1/2] ath10k: Convert ath10k_dbg uses In-Reply-To: <1369065683.2143.16.camel@joe-AO722> (Joe Perches's message of "Mon, 20 May 2013 09:01:23 -0700") References: <20130515143356.4492.43033.stgit@localhost6.localdomain6> <1368639816.2194.9.camel@joe-AO722> <8761yknn7i.fsf@kamboji.qca.qualcomm.com> <1368687816.2194.49.camel@joe-AO722> <51949805.7010509@tieto.com> <8738tii0qj.fsf@kamboji.qca.qualcomm.com> <1369065683.2143.16.camel@joe-AO722> Message-ID: <874ndxfq5x.fsf@kamboji.qca.qualcomm.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Joe Perches writes: > On Mon, 2013-05-20 at 10:12 +0300, Kalle Valo wrote: >> Michal Kazior writes: >> >> > On 16/05/13 09:03, Joe Perches wrote: >> >> Neaten and shorten the uses of ath10k_dbg and ath10k_dbg_dump. >> >> >> >> Add macros to hold the "ATH10K_DBG_" mask portion of the functions. >> > >> > I'm not really fond of this idea. It's harder to locate symbols when >> > doing macro name concatenation. You can't jump to, e.g. WMI symbol >> > definition because it doesn't exist (ATH10K_DBG_WMI is what you >> > actually want). Although you don't look for this symbol often so I >> > guess it's okay-ish. >> >> That's a good point. I sometimes use cscope to find all messages with >> certain level, this patch makes that impossible. And I don't really see >> that we have problems with ATH10K_DBG_WMI being too long. > > from the diffstat: 12 files changed, 226 insertions(+), 260 deletions(-) > > Reducing the line count has value Sure, but there's a limit to that as well. If it makes more difficult for the developers is it worth saving 30 lines? > grep -w works well for me, but I'm not a cscope user. I didn't know about -w, that's handy. Thanks. -- Kalle Valo