From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Mon, 10 Jun 2013 19:53:35 +0300 Subject: [ath9k-devel] [PATCH 02/10] ath10k: decouple core init/deinit logic In-Reply-To: <1370514361-15858-3-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 6 Jun 2013 12:25:53 +0200") References: <1370514361-15858-1-git-send-email-michal.kazior@tieto.com> <1370514361-15858-3-git-send-email-michal.kazior@tieto.com> Message-ID: <87hah5ucts.fsf@kamboji.qca.qualcomm.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Michal Kazior writes: > Enables code reuse for proper hw reconfiguration > that is in turn required for proper > suspend/hibernation/wowlan support. > > Signed-off-by: Michal Kazior Let's have a terminology check. I have understood we use terms with meaning like this (maybe you have been thinking something else): init(): initilises the module in question from host side, allocates memory etc. Called only once when driver is loaded. deinit(): reverse action for init(), frees allocated memory etc. Called only once. start(): Initialises hw/fw. Called every time we start the firmware. stop(): Kills the running fw. Shuts down all power the device (when possible) But here ath10k_core_init() seems to be initialising hw/fw. So should it be renamed to ath10k_core_start()? -- Kalle Valo