From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Thu, 18 Apr 2013 12:44:59 +0300 Subject: [ath9k-devel] [PATCH 1/5] ath10k: replace debug_mtx with conf_mutex In-Reply-To: <1366178645-13983-2-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Wed, 17 Apr 2013 08:04:01 +0200") References: <1366178645-13983-1-git-send-email-michal.kazior@tieto.com> <1366178645-13983-2-git-send-email-michal.kazior@tieto.com> Message-ID: <87ip3kqijo.fsf@kamboji.qca.qualcomm.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Michal Kazior writes: > It's not a good to have too many mutexes. The > patch simplifies locking of debufs to use > conf_mutex. > > Signed-off-by: Michal Kazior [...] > @@ -328,7 +328,7 @@ int ath10k_debug_create(struct ath10k *ar) > return -ENOMEM; > > init_completion(&ar->debug.event_stats_compl); > - mutex_init(&ar->debug.debug_mtx); > + mutex_init(&ar->conf_mutex); Can this be right? We already initialise conf_mutex in core.c. -- Kalle Valo