From: Kalle Valo <kvalo@qca.qualcomm.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 6/7] ath10k: introduce proper htt tx flow control
Date: Tue, 28 May 2013 18:06:52 +0300 [thread overview]
Message-ID: <87obbv6t4j.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1368695347-18467-7-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 16 May 2013 11:09:06 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> There were cases where we'd run out of msdu_ids.
> This can be fixed by telling mac80211 to stop
> sending us more frames if we run out of resources.
>
> It was possible to trigger with massive TCP RX
> ~300mbps (e.g. using iperf).
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
[...]
> +void __ath10k_htt_tx_dec_pending(struct ath10k_htt *htt)
> +{
> + htt->num_pending_tx--;
> + if (htt->num_pending_tx == HTT_MAX_NUM_PENDING_TX - 1)
> + ieee80211_wake_queues(htt->ar->hw);
> +}
How often is this function called? I'm wondering if it should be an
inline function.
But that can be done in a followup patch (if needed).
--
Kalle Valo
next prev parent reply other threads:[~2013-05-28 15:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 9:09 [ath9k-devel] [PATCH 0/7] ath10k: tx flow control fixes Michal Kazior
2013-05-16 9:09 ` [ath9k-devel] [PATCH 1/7] ath10k: change errno if we run out of msdu_ids Michal Kazior
2013-05-16 9:09 ` [ath9k-devel] [PATCH 2/7] ath10k: ath10k_htc_prepare_tx_skb() never fails Michal Kazior
2013-05-16 9:09 ` [ath9k-devel] [PATCH 3/7] ath10k: add lockdep asserts to htc skb dequeuing Michal Kazior
2013-05-16 9:09 ` [ath9k-devel] [PATCH 4/7] ath10k: simplify htc flow control Michal Kazior
2013-05-16 9:09 ` [ath9k-devel] [PATCH 5/7] ath10k: remove unused queue limit Michal Kazior
2013-05-16 9:09 ` [ath9k-devel] [PATCH 6/7] ath10k: introduce proper htt tx flow control Michal Kazior
2013-05-28 15:06 ` Kalle Valo [this message]
2013-05-29 6:00 ` Michal Kazior
2013-05-16 9:09 ` [ath9k-devel] [PATCH 7/7] ath10k: detect htt pending tx limit at runtime Michal Kazior
2013-06-03 8:35 ` Felix Fietkau
2013-05-28 15:07 ` [ath9k-devel] [PATCH 0/7] ath10k: tx flow control fixes Kalle Valo
2013-05-28 15:11 ` Kalle Valo
2013-05-29 6:46 ` [ath9k-devel] [PATCH] ath10k: fix sparse warning Michal Kazior
2013-06-01 9:12 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obbv6t4j.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox