From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Mon, 22 Apr 2013 12:38:49 +0300 Subject: [ath9k-devel] [PATCH] ath10k: split ath10k_pci_target_ps_control In-Reply-To: <517502D4.90303@tieto.com> (Markowski Bartosz's message of "Mon, 22 Apr 2013 11:28:52 +0200") References: <1366289226-4676-1-git-send-email-bartosz.markowski@tieto.com> <8738ujkl4y.fsf@kamboji.qca.qualcomm.com> <538FB72AA9C7314998FCE2FB41335C5A376AA61276@EXMB02.eu.tieto.com> <517502D4.90303@tieto.com> Message-ID: <87txmyj45y.fsf@kamboji.qca.qualcomm.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Markowski Bartosz writes: > On 22/04/13 10:50, Bartosz.Markowski at tieto.com wrote: >>> -----Original Message----- >>> From: Kalle Valo [mailto:kvalo at qca.qualcomm.com] >>> >>> And I think we can change ath10k_target_ps to static now. >> Yes. I will send a patch-set with this and remaining rebases after you iterate over the list. >> > hmm, seems like we actually can't make it static yet. > The ath10k_pci_sleep/wake() are called from ce and pci code. Sorry, I don't understand how that prevents making the variable static. Just to be clear, I was thinking doing something like this: diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 4bba532..9c650df 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -33,7 +33,7 @@ #include "ce.h" #include "pci.h" -unsigned int ath10k_target_ps; +static unsigned int ath10k_target_ps; module_param(ath10k_target_ps, uint, 0644); MODULE_PARM_DESC(ath10k_target_ps, "Enable ath10k Target (SoC) PS option"); diff --git a/drivers/net/wireless/ath/ath10k/pci.h b/drivers/net/wireless/ath/ath10k/pci.h index a3b5e88..e0ed0b0 100644 --- a/drivers/net/wireless/ath/ath10k/pci.h +++ b/drivers/net/wireless/ath/ath10k/pci.h @@ -353,8 +353,6 @@ static inline void WAR_CE_SRC_RING_WRITE_IDX_SET(struct ath10k *ar, } } -extern unsigned int ath10k_target_ps; - void ath10k_pci_wake(struct ath10k *ar); void ath10k_pci_sleep(struct ath10k *ar);