[ath9k-devel] [PATCH RFC 0/2] ath9k: AR9220 mini PCI card with inverted LED polarity

[ath9k-devel] [PATCH RFC 0/2] ath9k: AR9220 mini PCI card with inverted LED polarity

[Vittorio Gambaletta]

Hello,

I've got a Wistron DNMA-92 (AR9220) card that has inverted LED polarity
(active high instead of active low).

It has PCI ID 168c:0029, Subsystem ID 168c:2096.

The problem is that it has the same Subsystem ID of the Compex WLM200NX [0].
The two cards share the same Atheros MB92 design, but I don't know if
that other card has an inverted LED too. Its datasheet unfortunately
doesn't say anything about the LED.

So, what should I do now?

1) Add a new PCOEM PCI_DEVICE_SUB entry to pci.c with .driver_data set
    to ATH9K_PCI_LED_ACT_HI, with the risk of reversing the polarity for
    the other card (in case it is actually active low);
2) Add a new module parameter, ath9k_led_active_high, so that I can
    handle my card in my /etc/modprobe.d/*.conf file;
3) Both, since the module parameter could be useful anyway ;)

(By the way, after the mail server problem I've actually created the patches,
so this is an RFC now!)

Cheers,
Vittorio G

[0] https://wikidevi.com/wiki/Compex_WLM200NX

[ath9k-devel] [PATCH RFC 1/2] ath9k: Add a module parameter to invert LED polarity.

[Vittorio Gambaletta]

The LED can be active high instead of active low on some hardware.

Signed-off-by: Vittorio Gambaletta <linuxbugs@vittgam.net>
---
 drivers/net/wireless/ath/ath9k/init.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
index ab7a1ac..b66a30e 100644
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
@@ -49,6 +49,10 @@ int ath9k_led_blink;
 module_param_named(blink, ath9k_led_blink, int, 0444);
 MODULE_PARM_DESC(blink, "Enable LED blink on activity");
 
+static int ath9k_led_active_high = -1;
+module_param_named(led_active_high, ath9k_led_active_high, int, 0444);
+MODULE_PARM_DESC(led_active_high, "Invert LED polarity");
+
 static int ath9k_btcoex_enable;
 module_param_named(btcoex_enable, ath9k_btcoex_enable, int, 0444);
 MODULE_PARM_DESC(btcoex_enable, "Enable wifi-BT coexistence");
@@ -600,6 +604,9 @@ static int ath9k_init_softc(u16 devid, struct ath_softc *sc,
 	if (ret)
 		return ret;
 
+	if (ath9k_led_active_high != -1)
+		ah->config.led_active_high = ath9k_led_active_high == 1;
+
 	/*
 	 * Enable WLAN/BT RX Antenna diversity only when:
 	 *

[ath9k-devel] [PATCH RFC 2/2] ath9k: Fix LED polarity for some Mini PCI AR9220 MB92 cards.

[Vittorio Gambaletta]

The Wistron DNMA-92 has inverted LED polarity (active high instead
of active low).

The same PCI Subsystem ID is also used by the Compex WLM200NX,
which is based on the same Atheros MB92 design.

Signed-off-by: Vittorio Gambaletta <linuxbugs@vittgam.net>
---
 drivers/net/wireless/ath/ath9k/pci.c |   10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/net/wireless/ath/ath9k/pci.c b/drivers/net/wireless/ath/ath9k/pci.c
index e6fef1b..7cdaf40 100644
--- a/drivers/net/wireless/ath/ath9k/pci.c
+++ b/drivers/net/wireless/ath/ath9k/pci.c
@@ -28,6 +28,16 @@ static const struct pci_device_id ath_pci_id_table[] = {
 	{ PCI_VDEVICE(ATHEROS, 0x0024) }, /* PCI-E */
 	{ PCI_VDEVICE(ATHEROS, 0x0027) }, /* PCI   */
 	{ PCI_VDEVICE(ATHEROS, 0x0029) }, /* PCI   */
+
+#ifdef CONFIG_ATH9K_PCOEM
+	/* Mini PCI AR9220 MB92 cards: Compex WLM200NX, Wistron DNMA-92 */
+	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_ATHEROS,
+			 0x0029,
+			 PCI_VENDOR_ID_ATHEROS,
+			 0x2096),
+	  .driver_data = ATH9K_PCI_LED_ACT_HI },
+#endif
+
 	{ PCI_VDEVICE(ATHEROS, 0x002A) }, /* PCI-E */
 
 #ifdef CONFIG_ATH9K_PCOEM