From: Paul Moore <paul@paul-moore.com>
To: Ricardo Robaina <rrobaina@redhat.com>,
audit@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: eparis@redhat.com, Ricardo Robaina <rrobaina@redhat.com>
Subject: Re: [PATCH 1/2] audit: drop BUG_ON() from audit_add_to_parent()
Date: Tue, 28 Jul 2026 15:53:45 -0400 [thread overview]
Message-ID: <176efbd2097ef7b8a25b09b5e1f7b2de@paul-moore.com> (raw)
In-Reply-To: <e0e6505a3f80912216dd834d25f330b818d73263.1785246707.git.rrobaina@redhat.com>
On Jul 28, 2026 Ricardo Robaina <rrobaina@redhat.com> wrote:
>
> The BUG_ON(!mutex_is_locked(&audit_filter_mutex)) check in
> audit_add_to_parent() will panic the kernel if the mutex is not held,
> which is too severe for this situation.
>
> Replace it with lockdep_assert_held(), instead.
>
> Signed-off-by: Ricardo Robaina <rrobaina@redhat.com>
> ---
> kernel/audit_watch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Merged into audit/dev, thanks.
--
paul-moore.com
next prev parent reply other threads:[~2026-07-28 19:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 14:14 [PATCH 0/2] audit: drop BUG_ON() calls Ricardo Robaina
2026-07-28 14:14 ` [PATCH 1/2] audit: drop BUG_ON() from audit_add_to_parent() Ricardo Robaina
2026-07-28 19:53 ` Paul Moore [this message]
2026-07-28 22:45 ` Ricardo Robaina
2026-07-28 14:14 ` [PATCH 2/2] audit: drop BUG_ON() from audit_signal_info_syscall() Ricardo Robaina
2026-07-28 19:53 ` Paul Moore
2026-07-28 22:46 ` Ricardo Robaina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176efbd2097ef7b8a25b09b5e1f7b2de@paul-moore.com \
--to=paul@paul-moore.com \
--cc=audit@vger.kernel.org \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rrobaina@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox