Re: [PATCH 1/6] fs/exec: Drop task_lock() inside __get_task_comm()

Matus Jokay
2024-06-04T13:31:26Z

Hi Yafang,

> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index c75fd46506df..56a927393a38 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -1083,7 +1083,7 @@ struct task_struct {
> *
> * - normally initialized setup_new_exec()
> * - access it with [gs]et_task_comm()
> - * - lock it with task_lock()
> + * - lock it with task_lock() for writing
since you are updating this comment, you might as well fix other comments concerning ->comm, e.g.

diff --git a/include/linux/sched.h b/include/linux/sched.h
index c75fd46506df..95b382d790d9 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1081,9 +1081,9 @@ struct task_struct {
/*
* executable name, excluding path.
*
- * - normally initialized setup_new_exec()
- * - access it with [gs]et_task_comm()
- * - lock it with task_lock()
+ * - normally initialized begin_new_exec()
+ * - access it with __[gs]et_task_comm()
+ * - lock it with task_lock() for writing
*/
char comm[TASK_COMM_LEN];

--
Thanks
mY