[PATCH v3 08/11] tsacct: Replace strncpy() with __get_task_comm()

Yafang Shao
2024-06-21T02:32:02Z

Using __get_task_comm() to read the task comm ensures that the name is
always NUL-terminated, regardless of the source string. This approach also
facilitates future extensions to the task comm.

Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
---
kernel/tsacct.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/tsacct.c b/kernel/tsacct.c
index 4252f0645b9e..6b094d5d9135 100644
--- a/kernel/tsacct.c
+++ b/kernel/tsacct.c
@@ -76,7 +76,7 @@ void bacct_add_tsk(struct user_namespace *user_ns,
stats->ac_minflt = tsk->min_flt;
stats->ac_majflt = tsk->maj_flt;

- strncpy(stats->ac_comm, tsk->comm, sizeof(stats->ac_comm));
+ __get_task_comm(stats->ac_comm, sizeof(stats->ac_comm), tsk);
}

--
2.39.1