public inbox for audit@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Moore <paul@paul-moore.com>
To: Casey Schaufler <casey@schaufler-ca.com>,
	casey@schaufler-ca.com, eparis@redhat.com,
	linux-security-module@vger.kernel.org, audit@vger.kernel.org
Cc: jmorris@namei.org, serge@hallyn.com, keescook@chromium.org,
	john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp,
	stephen.smalley.work@gmail.com, linux-kernel@vger.kernel.org,
	selinux@vger.kernel.org
Subject: Re: [PATCH v3 5/5] Audit: Add record for multiple object contexts
Date: Thu, 24 Apr 2025 18:18:34 -0400	[thread overview]
Message-ID: <5e95e5d8b2b262548220382f14fcb3e4@paul-moore.com> (raw)
In-Reply-To: <20250319222744.17576-6-casey@schaufler-ca.com>

On Mar 19, 2025 Casey Schaufler <casey@schaufler-ca.com> wrote:
> 
> Create a new audit record AUDIT_MAC_OBJ_CONTEXTS.
> An example of the MAC_OBJ_CONTEXTS (1424) record is:
> 
>     type=MAC_OBJ_CONTEXTS[1424]
>     msg=audit(1601152467.009:1050):
>     obj_selinux=unconfined_u:object_r:user_home_t:s0
> 
> When an audit event includes a AUDIT_MAC_OBJ_CONTEXTS record
> the "obj=" field in other records in the event will be "obj=?".
> An AUDIT_MAC_OBJ_CONTEXTS record is supplied when the system has
> multiple security modules that may make access decisions based
> on an object security context.
> 
> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
> ---
>  include/linux/audit.h      |  6 +++++
>  include/uapi/linux/audit.h |  1 +
>  kernel/audit.c             | 51 +++++++++++++++++++++++++++++++++++++-
>  kernel/auditsc.c           | 45 ++++++++-------------------------
>  4 files changed, 68 insertions(+), 35 deletions(-)

Similar to patch 4/5, this looks fine modulo the obj count changes.

Related, you changed to a single subj/obj count in v3, is it no longer
important to distinguish between the two?

--
paul-moore.com

      reply	other threads:[~2025-04-24 22:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250319222744.17576-1-casey.ref@schaufler-ca.com>
2025-03-19 22:27 ` [PATCH v3 0/5] Audit: Records for multiple security contexts Casey Schaufler
2025-03-19 22:27   ` [PATCH v3 1/5] Audit: Create audit_stamp structure Casey Schaufler
2025-04-24 22:18     ` Paul Moore
2025-03-19 22:27   ` [PATCH v3 2/5] LSM: security_lsmblob_to_secctx module selection Casey Schaufler
2025-03-25 23:44     ` Fan Wu
2025-03-26 14:57       ` Casey Schaufler
2025-04-24 22:18     ` Paul Moore
2025-03-19 22:27   ` [PATCH v3 3/5] Audit: Add record for multiple task security contexts Casey Schaufler
2025-04-24 22:18     ` Paul Moore
2025-03-19 22:27   ` [PATCH v3 4/5] Audit: multiple subject lsm values for netlabel Casey Schaufler
2025-04-24 22:18     ` Paul Moore
2025-04-30 16:25       ` Casey Schaufler
2025-04-30 18:51         ` Paul Moore
2025-04-30 20:48           ` Casey Schaufler
2025-03-19 22:27   ` [PATCH v3 5/5] Audit: Add record for multiple object contexts Casey Schaufler
2025-04-24 22:18     ` Paul Moore [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e95e5d8b2b262548220382f14fcb3e4@paul-moore.com \
    --to=paul@paul-moore.com \
    --cc=audit@vger.kernel.org \
    --cc=casey@schaufler-ca.com \
    --cc=eparis@redhat.com \
    --cc=jmorris@namei.org \
    --cc=john.johansen@canonical.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=selinux@vger.kernel.org \
    --cc=serge@hallyn.com \
    --cc=stephen.smalley.work@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox