Re: [PATCH v2 6/6] Audit: Add record for multiple object contexts

Dan Carpenter
2025-03-10T08:20:54Z

Hi Casey,

kernel test robot noticed the following build warnings:

https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Casey-Schaufler/Audit-Create-audit_stamp-structure/20250308-024950
base: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git next
patch link: https://lore.kernel.org/r/20250307183701.16970-7-casey%40schaufler-ca.com
patch subject: [PATCH v2 6/6] Audit: Add record for multiple object contexts
config: powerpc64-randconfig-r073-20250309 (https://download.01.org/0day-ci/archive/20250310/202503100802.Dqju4qc5-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 14.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202503100802.Dqju4qc5-lkp@intel.com/

smatch warnings:
kernel/auditsc.c:1753 audit_log_exit() warn: if statement not indented

vim +1753 kernel/auditsc.c

e54dc2431d740a Amy Griffis 2007-03-29 1749 for (aux = context->aux_pids; aux; aux = aux->next) {
e54dc2431d740a Amy Griffis 2007-03-29 1750 struct audit_aux_data_pids *axs = (void *)aux;
e54dc2431d740a Amy Griffis 2007-03-29 1751
e54dc2431d740a Amy Griffis 2007-03-29 1752 for (i = 0; i < axs->pid_count; i++)
e54dc2431d740a Amy Griffis 2007-03-29 @1753 if (audit_log_pid_context(context, axs->target_pid[i],
c2a7780efe37d0 Eric Paris 2008-01-07 1754 axs->target_auid[i],
c2a7780efe37d0 Eric Paris 2008-01-07 1755 axs->target_uid[i],
4746ec5b01ed07 Eric Paris 2008-01-08 1756 axs->target_sessionid[i],
13d826e564e2cc Casey Schaufler 2024-10-09 1757 &axs->target_ref[i],
c2a7780efe37d0 Eric Paris 2008-01-07 1758 axs->target_comm[i]))
e54dc2431d740a Amy Griffis 2007-03-29 1759 call_panic = 1;

This should be indented another tab.

a5cb013da773a6 Al Viro 2007-03-20 1760 }
a5cb013da773a6 Al Viro 2007-03-20 1761
e54dc2431d740a Amy Griffis 2007-03-29 1762 if (context->target_pid &&
e54dc2431d740a Amy Griffis 2007-03-29 1763 audit_log_pid_context(context, context->target_pid,
c2a7780efe37d0 Eric Paris 2008-01-07 1764 context->target_auid, context->target_uid,
4746ec5b01ed07 Eric Paris 2008-01-08 1765 context->target_sessionid,

--
0-DAY CI Kernel Test Service