Re: [PATCH v16 01/20] security: add ipe lsm

Jarkko Sakkinen
2024-03-30T11:11:31Z

On Fri Mar 29, 2024 at 12:11 AM EET, Randy Dunlap wrote:
>
>
> On 3/28/24 13:45, Jarkko Sakkinen wrote:
> >> +/**
> >> + * ipe_init - Entry point of IPE.
> >> + *
> >> + * This is called at LSM init, which happens occurs early during kernel
> >> + * start up. During this phase, IPE registers its hooks and loads the
> >> + * builtin boot policy.
> >> + * Return:
> >> + * * 0 - OK
> >> + * * -ENOMEM - Out of memory
> > Just a suggestion:
> >
> > * 0: OK
> > * -ENOMEM: Out of memory (OOM)
> >
> > Rationale being more readable (less convoluted).
> >
> > And also sort of symmetrical how parameters are formatted in kdoc.
>
> It needs the " * *" to make a formatted list in the generated output.
> Otherwise the use of '- or ':' as a separator doesn't matter AFAIK.

Thanks for the remark! Yeah I don't mind the two stars.

BR, Jarkko