From: Richard Guy Briggs <rgb@redhat.com>
To: Ricardo Robaina <rrobaina@redhat.com>
Cc: Paul Moore <paul@paul-moore.com>,
audit@vger.kernel.org, linux-kernel@vger.kernel.org,
eparis@redhat.com, viro@zeniv.linux.org.uk
Subject: Re: [PATCH v2] audit: fix suffixed '/' filename matching in __audit_inode_child()
Date: Fri, 6 Dec 2024 10:17:53 -0500 [thread overview]
Message-ID: <Z1MVodP9Xien/Dv8@madcap2.tricolour.ca> (raw)
In-Reply-To: <CAABTaaBQ0+tSx++xYB2NJ=3Qkein9Y5=eY0uU-V9Qb6mR28GvQ@mail.gmail.com>
On 2024-12-06 10:00, Ricardo Robaina wrote:
> On Thu, Dec 5, 2024 at 9:22 PM Paul Moore <paul@paul-moore.com> wrote:
> >
> > Yes, Richard did provide a reviewed-by tag on the v1 patch, but v2 has
> > enough changes that I don't think we can reasonably carry that forward;
> > of course Richard re-review this iteration and provide a new tag. I'm
> > going to remove it for now.
> >
> > Al never provided an explicit reviewed-by tag; simply commenting on a
> > patch is not the same as providing a 'Reviewed-by', the reviewer will
> > provide an explicit 'Reviewed-by' tag in their email. I'm going to
> > remove Al's tag too.
>
> I'm sorry about that, I was just trying to give credit to the ones who
> helped. Thanks for clarifying the expected review process, I
> appreciate it!
Please re-add my reviewed-by tag.
> > Other than those issues, I think this looks much better than v1, I'm
> > going to merge this into audit/dev now, thanks!
>
> Thanks, Paul!
>
> - Ricardo
- RGB
--
Richard Guy Briggs <rgb@redhat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
Upstream IRC: SunRaycer
Voice: +1.613.860 2354 SMS: +1.613.518.6570
next prev parent reply other threads:[~2024-12-06 15:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 12:18 [PATCH v2] audit: fix suffixed '/' filename matching in __audit_inode_child() Ricardo Robaina
2024-12-06 0:22 ` Paul Moore
2024-12-06 13:00 ` Ricardo Robaina
2024-12-06 15:17 ` Richard Guy Briggs [this message]
2024-12-06 21:57 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1MVodP9Xien/Dv8@madcap2.tricolour.ca \
--to=rgb@redhat.com \
--cc=audit@vger.kernel.org \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=rrobaina@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox