From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>,
netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>,
audit@vger.kernel.org, Paul Moore <paul@paul-moore.com>,
Richard Guy Briggs <rgb@redhat.com>
Subject: Re: [nf PATCH 2/3] netfilter: nf_tables: Deduplicate nft_register_obj audit logs
Date: Thu, 28 Sep 2023 21:14:42 +0200 [thread overview]
Message-ID: <ZRXQog2knfZ5n6Jp@calendula> (raw)
In-Reply-To: <ZRWSKxKXjzlFHl7G@orbyte.nwl.cc>
On Thu, Sep 28, 2023 at 04:48:11PM +0200, Phil Sutter wrote:
> On Wed, Sep 27, 2023 at 09:41:53PM +0200, Pablo Neira Ayuso wrote:
> > OK, so nft_obj_notify() is called from nft_quota to notify that the
> > quota is depleted and the audit log is still there in this case.
>
> Exactly. I needed an internal __nft_obj_notify() which just serves
> notify_list but not audit.
Patch LGTM, thanks for explaining!
next prev parent reply other threads:[~2023-09-28 19:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 1:53 [nf PATCH 0/3] Review nf_tables audit logging Phil Sutter
2023-09-23 1:53 ` [nf PATCH 1/3] selftests: netfilter: Extend nft_audit.sh Phil Sutter
2023-09-23 1:53 ` [nf PATCH 2/3] netfilter: nf_tables: Deduplicate nft_register_obj audit logs Phil Sutter
2023-09-27 19:41 ` Pablo Neira Ayuso
2023-09-28 14:48 ` Phil Sutter
2023-09-28 19:14 ` Pablo Neira Ayuso [this message]
2023-09-28 1:37 ` Richard Guy Briggs
2023-10-03 17:50 ` Paul Moore
2023-09-23 1:53 ` [nf PATCH 3/3] netfilter: nf_tables: Audit log object reset once per table Phil Sutter
2023-09-28 17:02 ` Richard Guy Briggs
2023-10-03 17:51 ` Paul Moore
2023-10-03 20:48 ` Florian Westphal
2023-09-26 21:24 ` [nf PATCH 0/3] Review nf_tables audit logging Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRXQog2knfZ5n6Jp@calendula \
--to=pablo@netfilter.org \
--cc=audit@vger.kernel.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=phil@nwl.cc \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox