[PATCH] audit: add a missing tab

[PATCH] audit: add a missing tab

[Dan Carpenter]

Someone got a bit carried away deleting tabs.  Add it back.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 kernel/auditsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index 1c29541c8fb6..497bda0043fb 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -1778,7 +1778,7 @@ static void audit_log_exit(void)
 						  axs->target_sessionid[i],
 						  &axs->target_ref[i],
 						  axs->target_comm[i]))
-			call_panic = 1;
+				call_panic = 1;
 	}
 
 	if (context->target_pid &&
-- 
2.47.2

Re: [PATCH] audit: add a missing tab

[Casey Schaufler]

On 8/12/2025 10:38 PM, Dan Carpenter wrote:
> Someone got a bit carried away deleting tabs.  Add it back.

Of course, it should be the way you want it to be, but I don't
see the reasoning. Help me understand.

>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  kernel/auditsc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index 1c29541c8fb6..497bda0043fb 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -1778,7 +1778,7 @@ static void audit_log_exit(void)
>  						  axs->target_sessionid[i],
>  						  &axs->target_ref[i],
>  						  axs->target_comm[i]))
> -			call_panic = 1;
> +				call_panic = 1;
>  	}
>  
>  	if (context->target_pid &&

Re: [PATCH] audit: add a missing tab

[Casey Schaufler]

On 8/13/2025 8:39 AM, Casey Schaufler wrote:
> On 8/12/2025 10:38 PM, Dan Carpenter wrote:
>> Someone got a bit carried away deleting tabs.  Add it back.
> Of course, it should be the way you want it to be, but I don't
> see the reasoning. Help me understand.

OK, I see it. Looks like a rebase error.

>
>> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
>> ---
>>  kernel/auditsc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
>> index 1c29541c8fb6..497bda0043fb 100644
>> --- a/kernel/auditsc.c
>> +++ b/kernel/auditsc.c
>> @@ -1778,7 +1778,7 @@ static void audit_log_exit(void)
>>  						  axs->target_sessionid[i],
>>  						  &axs->target_ref[i],
>>  						  axs->target_comm[i]))
>> -			call_panic = 1;
>> +				call_panic = 1;
>>  	}
>>  
>>  	if (context->target_pid &&

Re: [PATCH] audit: add a missing tab

[Dan Carpenter]

On Wed, Aug 13, 2025 at 08:39:33AM -0700, Casey Schaufler wrote:
> On 8/12/2025 10:38 PM, Dan Carpenter wrote:
> > Someone got a bit carried away deleting tabs.  Add it back.
> 
> Of course, it should be the way you want it to be, but I don't
> see the reasoning. Help me understand.
> 

The "call_panic = 1;" has to be indent one tab more than the
if (audit_log_pid_context()) check otherwise static checkers complain
that the if statement isn't indented.

  1771  ________for (aux = context->aux_pids; aux; aux = aux->next) {
  1772  ________        struct audit_aux_data_pids *axs = (void *)aux;
  1773  ________
  1774  ________        for (i = 0; i < axs->pid_count; i++)
  1775  ________        ________if (audit_log_pid_context(context, axs->target_pid[i],
  1776  ________        ________                          axs->target_auid[i],
  1777  ________        ________                          axs->target_uid[i],
  1778  ________        ________                          axs->target_sessionid[i],
  1779  ________        ________                          &axs->target_ref[i],
  1780  ________        ________                          axs->target_comm[i]))
  1781  ________        ________        call_panic = 1;
  1782  ________}

regards,
dan carpenter

Re: [PATCH] audit: add a missing tab

[Paul Moore]

On Aug 13, 2025 Dan Carpenter <dan.carpenter@linaro.org> wrote:
> 
> Someone got a bit carried away deleting tabs.  Add it back.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  kernel/auditsc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Good catch, thanks Dan; merged into audit/dev.

--
paul-moore.com