* [PATCH] audit: add a missing tab
@ 2025-08-13 5:38 Dan Carpenter
2025-08-13 15:39 ` Casey Schaufler
2025-08-13 15:51 ` Paul Moore
0 siblings, 2 replies; 5+ messages in thread
From: Dan Carpenter @ 2025-08-13 5:38 UTC (permalink / raw)
To: Casey Schaufler; +Cc: Paul Moore, Eric Paris, audit, kernel-janitors
Someone got a bit carried away deleting tabs. Add it back.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
kernel/auditsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index 1c29541c8fb6..497bda0043fb 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -1778,7 +1778,7 @@ static void audit_log_exit(void)
axs->target_sessionid[i],
&axs->target_ref[i],
axs->target_comm[i]))
- call_panic = 1;
+ call_panic = 1;
}
if (context->target_pid &&
--
2.47.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] audit: add a missing tab
2025-08-13 5:38 [PATCH] audit: add a missing tab Dan Carpenter
@ 2025-08-13 15:39 ` Casey Schaufler
2025-08-13 15:45 ` Casey Schaufler
2025-08-13 15:48 ` Dan Carpenter
2025-08-13 15:51 ` Paul Moore
1 sibling, 2 replies; 5+ messages in thread
From: Casey Schaufler @ 2025-08-13 15:39 UTC (permalink / raw)
To: Dan Carpenter
Cc: Paul Moore, Eric Paris, audit, kernel-janitors, Casey Schaufler
On 8/12/2025 10:38 PM, Dan Carpenter wrote:
> Someone got a bit carried away deleting tabs. Add it back.
Of course, it should be the way you want it to be, but I don't
see the reasoning. Help me understand.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> kernel/auditsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index 1c29541c8fb6..497bda0043fb 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -1778,7 +1778,7 @@ static void audit_log_exit(void)
> axs->target_sessionid[i],
> &axs->target_ref[i],
> axs->target_comm[i]))
> - call_panic = 1;
> + call_panic = 1;
> }
>
> if (context->target_pid &&
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] audit: add a missing tab
2025-08-13 15:39 ` Casey Schaufler
@ 2025-08-13 15:45 ` Casey Schaufler
2025-08-13 15:48 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Casey Schaufler @ 2025-08-13 15:45 UTC (permalink / raw)
To: Dan Carpenter
Cc: Paul Moore, Eric Paris, audit, kernel-janitors, Casey Schaufler
On 8/13/2025 8:39 AM, Casey Schaufler wrote:
> On 8/12/2025 10:38 PM, Dan Carpenter wrote:
>> Someone got a bit carried away deleting tabs. Add it back.
> Of course, it should be the way you want it to be, but I don't
> see the reasoning. Help me understand.
OK, I see it. Looks like a rebase error.
>
>> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
>> ---
>> kernel/auditsc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
>> index 1c29541c8fb6..497bda0043fb 100644
>> --- a/kernel/auditsc.c
>> +++ b/kernel/auditsc.c
>> @@ -1778,7 +1778,7 @@ static void audit_log_exit(void)
>> axs->target_sessionid[i],
>> &axs->target_ref[i],
>> axs->target_comm[i]))
>> - call_panic = 1;
>> + call_panic = 1;
>> }
>>
>> if (context->target_pid &&
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] audit: add a missing tab
2025-08-13 15:39 ` Casey Schaufler
2025-08-13 15:45 ` Casey Schaufler
@ 2025-08-13 15:48 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2025-08-13 15:48 UTC (permalink / raw)
To: Casey Schaufler; +Cc: Paul Moore, Eric Paris, audit, kernel-janitors
On Wed, Aug 13, 2025 at 08:39:33AM -0700, Casey Schaufler wrote:
> On 8/12/2025 10:38 PM, Dan Carpenter wrote:
> > Someone got a bit carried away deleting tabs. Add it back.
>
> Of course, it should be the way you want it to be, but I don't
> see the reasoning. Help me understand.
>
The "call_panic = 1;" has to be indent one tab more than the
if (audit_log_pid_context()) check otherwise static checkers complain
that the if statement isn't indented.
1771 ________for (aux = context->aux_pids; aux; aux = aux->next) {
1772 ________ struct audit_aux_data_pids *axs = (void *)aux;
1773 ________
1774 ________ for (i = 0; i < axs->pid_count; i++)
1775 ________ ________if (audit_log_pid_context(context, axs->target_pid[i],
1776 ________ ________ axs->target_auid[i],
1777 ________ ________ axs->target_uid[i],
1778 ________ ________ axs->target_sessionid[i],
1779 ________ ________ &axs->target_ref[i],
1780 ________ ________ axs->target_comm[i]))
1781 ________ ________ call_panic = 1;
1782 ________}
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] audit: add a missing tab
2025-08-13 5:38 [PATCH] audit: add a missing tab Dan Carpenter
2025-08-13 15:39 ` Casey Schaufler
@ 2025-08-13 15:51 ` Paul Moore
1 sibling, 0 replies; 5+ messages in thread
From: Paul Moore @ 2025-08-13 15:51 UTC (permalink / raw)
To: Dan Carpenter, Casey Schaufler; +Cc: Eric Paris, audit, kernel-janitors
On Aug 13, 2025 Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> Someone got a bit carried away deleting tabs. Add it back.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> kernel/auditsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Good catch, thanks Dan; merged into audit/dev.
--
paul-moore.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-08-13 16:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-13 5:38 [PATCH] audit: add a missing tab Dan Carpenter
2025-08-13 15:39 ` Casey Schaufler
2025-08-13 15:45 ` Casey Schaufler
2025-08-13 15:48 ` Dan Carpenter
2025-08-13 15:51 ` Paul Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox