public inbox for audit@vger.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Ricardo Robaina <rrobaina@redhat.com>
Cc: Paul Moore <paul@paul-moore.com>,
	audit@vger.kernel.org, linux-kernel@vger.kernel.org,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	eparis@redhat.com, pablo@netfilter.org, kadlec@netfilter.org
Subject: Re: [PATCH v5 1/2] audit: add audit_log_packet_ip4 and audit_log_packet_ip6 helper functions
Date: Mon, 10 Nov 2025 13:43:48 +0100	[thread overview]
Message-ID: <aRHd_WFBcyiL1Ufe@strlen.de> (raw)
In-Reply-To: <CAABTaaCVsFOmouRZED_DTMPy_EimSAsercz=8A3RLTUYnpvf_A@mail.gmail.com>

Ricardo Robaina <rrobaina@redhat.com> wrote:
> > +int audit_log_nft_skb(struct audit_buffer *ab,
> > +                     struct sk_buff *skb, u8 nfproto)
> Thanks for reviewing this patch, Paul.
> 
> It makes sense to me. I'll work on a newer version addressing your suggestions.

Nit, but as you need to resend anyway, can you also make this
'const struct sk_buff *' ?

Also, given this isn't nftables specific, I suggest
audit_log_nf_skb, audit_log_netfilter_skb or some such instead.

Thanks.

  reply	other threads:[~2025-11-10 12:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-06 16:53 [PATCH v5 0/2] audit: improve NETFILTER_PKT records Ricardo Robaina
2025-11-06 16:53 ` [PATCH v5 1/2] audit: add audit_log_packet_ip4 and audit_log_packet_ip6 helper functions Ricardo Robaina
2025-11-07 22:46   ` Paul Moore
2025-11-10 12:16     ` Ricardo Robaina
2025-11-10 12:43       ` Florian Westphal [this message]
2025-11-11 11:05         ` Ricardo Robaina
2025-11-06 16:53 ` [PATCH v5 2/2] audit: include source and destination ports to NETFILTER_PKT Ricardo Robaina
2025-11-07 22:46   ` Paul Moore
2025-11-10 12:30     ` Ricardo Robaina
2025-11-06 23:21 ` [PATCH v5 0/2] audit: improve NETFILTER_PKT records Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aRHd_WFBcyiL1Ufe@strlen.de \
    --to=fw@strlen.de \
    --cc=audit@vger.kernel.org \
    --cc=coreteam@netfilter.org \
    --cc=eparis@redhat.com \
    --cc=kadlec@netfilter.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=paul@paul-moore.com \
    --cc=rrobaina@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox