From: Paul Moore <paul@paul-moore.com>
To: Sergio Correia <scorreia@redhat.com>,
audit@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: eparis@redhat.com, rrobaina@redhat.com,
Sergio Correia <scorreia@redhat.com>
Subject: Re: [PATCH] audit: enforce AUDIT_LOCKED for AUDIT_TRIM and AUDIT_MAKE_EQUIV
Date: Tue, 12 May 2026 16:10:36 -0400 [thread overview]
Message-ID: <c75e43417311f8f594ed94d96e4950c2@paul-moore.com> (raw)
In-Reply-To: <20260512132859.1305499-1-scorreia@redhat.com>
On May 12, 2026 Sergio Correia <scorreia@redhat.com> wrote:
>
> AUDIT_ADD_RULE and AUDIT_DEL_RULE correctly check for AUDIT_LOCKED
> and return -EPERM, but AUDIT_TRIM and AUDIT_MAKE_EQUIV do not. This
> allows a process with CAP_AUDIT_CONTROL to modify directory tree
> watches and equivalence mappings even when the audit configuration
> has been locked, undermining the purpose of the lock.
>
> Add AUDIT_LOCKED checks to both commands.
>
> Reviewed-by: Ricardo Robaina <rrobaina@redhat.com>
> Assisted-by: Claude:claude-opus-4-6
> Signed-off-by: Sergio Correia <scorreia@redhat.com>
> ---
> kernel/audit.c | 4 ++++
> 1 file changed, 4 insertions(+)
Merged into audit/stable-7.1 with the expectation of sending it up to
Linus later this week, thanks!
--
paul-moore.com
prev parent reply other threads:[~2026-05-12 20:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 13:28 [PATCH] audit: enforce AUDIT_LOCKED for AUDIT_TRIM and AUDIT_MAKE_EQUIV Sergio Correia
2026-05-12 20:10 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c75e43417311f8f594ed94d96e4950c2@paul-moore.com \
--to=paul@paul-moore.com \
--cc=audit@vger.kernel.org \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rrobaina@redhat.com \
--cc=scorreia@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox